[linux-next:master 7056/7206] kernel/time/timekeeping.c:1096: undefined reference to `stop_machine'

[linux-next:master 7056/7206] kernel/time/timekeeping.c:1096: undefined reference to `stop_machine'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f7ac28a6971b43a2ee8bb47c0ef931b38f7888cf
commit: 64dab25b058c12f935794cb239089303bda7dbc1 [7056/7206] kernel/stop_machine.c: remove CONFIG_SMP dependencies
config: m32r-usrv_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 64dab25b058c12f935794cb239089303bda7dbc1
        # save the attached .config to linux build tree
        make.cross ARCH=m32r 

All errors (new ones prefixed by >>):

   kernel/built-in.o: In function `timekeeping_notify':
>> kernel/time/timekeeping.c:1096: undefined reference to `stop_machine'
   kernel/time/timekeeping.c:1096:(.text+0x51498): relocation truncated to fit: R_M32R_26_PCREL_RELA against undefined symbol `stop_machine'
   mm/built-in.o: In function `build_all_zonelists':
>> mm/page_alloc.c:4508: undefined reference to `stop_machine'
   mm/page_alloc.c:4508:(.ref.text+0x1f4): relocation truncated to fit: R_M32R_26_PCREL_RELA against undefined symbol `stop_machine'

vim +1096 kernel/time/timekeeping.c

ba919d1c Thomas Gleixner    2013-04-25  1090  int timekeeping_notify(struct clocksource *clock)
75c5158f Martin Schwidefsky 2009-08-14  1091  {
3fdb14fd Thomas Gleixner    2014-07-16  1092  	struct timekeeper *tk = &tk_core.timekeeper;
4e250fdd John Stultz        2012-07-27  1093  
876e7881 Peter Zijlstra     2015-03-19  1094  	if (tk->tkr_mono.clock == clock)
ba919d1c Thomas Gleixner    2013-04-25  1095  		return 0;
75c5158f Martin Schwidefsky 2009-08-14 @1096  	stop_machine(change_clocksource, clock, NULL);
8524070b John Stultz        2007-05-08  1097  	tick_clock_notify();
876e7881 Peter Zijlstra     2015-03-19  1098  	return tk->tkr_mono.clock == clock ? 0 : -1;
8524070b John Stultz        2007-05-08  1099  }

:::::: The code at line 1096 was first introduced by commit
:::::: 75c5158f70c065b9704b924503d96e8297838f79 timekeeping: Update clocksource with stop_machine

:::::: TO: Martin Schwidefsky <schwidefsky@de.ibm.com>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 7956 bytes --]

Re: [linux-next:master 7056/7206] kernel/time/timekeeping.c:1096: undefined reference to `stop_machine'

[Andrew Morton]

On Fri, 18 Dec 2015 22:39:22 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   f7ac28a6971b43a2ee8bb47c0ef931b38f7888cf
> commit: 64dab25b058c12f935794cb239089303bda7dbc1 [7056/7206] kernel/stop_machine.c: remove CONFIG_SMP dependencies
> config: m32r-usrv_defconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 64dab25b058c12f935794cb239089303bda7dbc1
>         # save the attached .config to linux build tree
>         make.cross ARCH=m32r 
> 
> All errors (new ones prefixed by >>):
> 
>    kernel/built-in.o: In function `timekeeping_notify':
> >> kernel/time/timekeeping.c:1096: undefined reference to `stop_machine'
>    kernel/time/timekeeping.c:1096:(.text+0x51498): relocation truncated to fit: R_M32R_26_PCREL_RELA against undefined symbol `stop_machine'
>    mm/built-in.o: In function `build_all_zonelists':
> >> mm/page_alloc.c:4508: undefined reference to `stop_machine'
>    mm/page_alloc.c:4508:(.ref.text+0x1f4): relocation truncated to fit: R_M32R_26_PCREL_RELA against undefined symbol `stop_machine'
> 

doh.

From: Andrew Morton <akpm@linux-foundation.org>
Subject: kernel-stop_machinec-remove-config_smp-dependencies-fix

stop_machine.o is only built if CONFIG_SMP=y, so this ifdef always
evaluates to true.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/stop_machine.c |    4 ----
 1 file changed, 4 deletions(-)

diff -puN kernel/stop_machine.c~kernel-stop_machinec-remove-config_smp-dependencies-fix kernel/stop_machine.c
--- a/kernel/stop_machine.c~kernel-stop_machinec-remove-config_smp-dependencies-fix
+++ a/kernel/stop_machine.c
@@ -531,8 +531,6 @@ static int __init cpu_stop_init(void)
 }
 early_initcall(cpu_stop_init);
 
-#ifdef CONFIG_HOTPLUG_CPU
-
 static int __stop_machine(cpu_stop_fn_t fn, void *data, const struct cpumask *cpus)
 {
 	struct multi_stop_data msdata = {
@@ -630,5 +628,3 @@ int stop_machine_from_inactive_cpu(cpu_s
 	mutex_unlock(&stop_cpus_mutex);
 	return ret ?: done.ret;
 }
-
-#endif	/* CONFIG_HOTPLUG_CPU */
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>