From: Catalin Marinas <catalin.marinas@arm.com>
To: zhongjiang <zhongjiang@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ryabinin.a.a@gmail.com" <ryabinin.a.a@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"qiuxishi@huawei.com" <qiuxishi@huawei.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] arm64: fix add kasan bug
Date: Tue, 5 Jan 2016 10:10:19 +0000 [thread overview]
Message-ID: <20160105101017.GA14545@localhost.localdomain> (raw)
In-Reply-To: <1451556549-8962-1-git-send-email-zhongjiang@huawei.com>
On Thu, Dec 31, 2015 at 10:09:09AM +0000, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> In general, each process have 16kb stack space to use, but
> stack need extra space to store red_zone when kasan enable.
> the patch fix above question.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm64/include/asm/thread_info.h | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h
> index 90c7ff2..45b5a7e 100644
> --- a/arch/arm64/include/asm/thread_info.h
> +++ b/arch/arm64/include/asm/thread_info.h
[...]
> +#ifdef CONFIG_KASAN
> +#define THREAD_SIZE 32768
> +#else
> #define THREAD_SIZE 16384
> +#endif
I'm not really keen on increasing the stack size to 32KB when KASan is
enabled (that's 8 4K pages). Have you actually seen a real problem with
the default size? How large is the red_zone?
With 4.5 we are going for separate IRQ stack on arm64, so the typical
stack overflow case no longer exists.
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-05 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 10:09 [PATCH] arm64: fix add kasan bug zhongjiang
2016-01-04 21:13 ` Andrew Morton
2016-01-05 10:13 ` Catalin Marinas
2016-01-05 10:10 ` Catalin Marinas [this message]
2016-01-05 21:17 ` Andrey Ryabinin
2016-01-08 18:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105101017.GA14545@localhost.localdomain \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=long.wanglong@huawei.com \
--cc=qiuxishi@huawei.com \
--cc=ryabinin.a.a@gmail.com \
--cc=will.deacon@arm.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).