Re: [PATCH] mm/mlock.c: change can_do_mlock return value type to boolean

Re: [PATCH] mm/mlock.c: change can_do_mlock return value type to boolean

[Andrew Morton]

On Fri, 8 Jan 2016 20:38:23 +0800 Wang Xiaoqiang <wangxq10@lzu.edu.cn> wrote:

> Since can_do_mlock only return 1 or 0, so make it boolean.
> 
> No functional change.
> 
> ...
>
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -24,13 +24,13 @@
>  
>  #include "internal.h"
>  
> -int can_do_mlock(void)
> +bool can_do_mlock(void)
>  {
>  	if (rlimit(RLIMIT_MEMLOCK) != 0)
> -		return 1;
> +		return true;
>  	if (capable(CAP_IPC_LOCK))
> -		return 1;
> -	return 0;
> +		return true;
> +	return false;
>  }
>  EXPORT_SYMBOL(can_do_mlock);

Please never send untested patches.  Ever.

--- a/include/linux/mm.h~mm-mlockc-change-can_do_mlock-return-value-type-to-boolean-fix
+++ a/include/linux/mm.h
@@ -1100,7 +1100,7 @@ static inline bool shmem_mapping(struct
 }
 #endif
 
-extern int can_do_mlock(void);
+extern bool can_do_mlock(void);
 extern int user_shm_lock(size_t, struct user_struct *);
 extern void user_shm_unlock(size_t, struct user_struct *);
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>