* [PATCH] mm/page_alloc: remove unused struct zone *z variable
@ 2016-01-08 7:59 Alexander Kuleshov
2016-01-08 23:29 ` Kirill A. Shutemov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kuleshov @ 2016-01-08 7:59 UTC (permalink / raw)
To: Andrew Morton
Cc: Mel Gorman, Michal Hocko, Vlastimil Babka, David Rientjes,
Joonsoo Kim, Yaowei Bai, Xishi Qiu, Alexander Duyck,
Kirill A . Shutemov, Johannes Weiner, linux-mm, linux-kernel,
Alexander Kuleshov
This patch removes unused struct zone *z variable which is
appeared in 86051ca5eaf5 (mm: fix usemap initialization)
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
mm/page_alloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9d666df..9bde098 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
pg_data_t *pgdat = NODE_DATA(nid);
unsigned long end_pfn = start_pfn + size;
unsigned long pfn;
- struct zone *z;
unsigned long nr_initialised = 0;
if (highest_memmap_pfn < end_pfn - 1)
highest_memmap_pfn = end_pfn - 1;
- z = &pgdat->node_zones[zone];
for (pfn = start_pfn; pfn < end_pfn; pfn++) {
/*
* There can be holes in boot-time mem_map[]s
--
2.6.2.485.g1bc8fea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable
2016-01-08 7:59 [PATCH] mm/page_alloc: remove unused struct zone *z variable Alexander Kuleshov
@ 2016-01-08 23:29 ` Kirill A. Shutemov
2016-01-11 13:51 ` Vlastimil Babka
0 siblings, 1 reply; 3+ messages in thread
From: Kirill A. Shutemov @ 2016-01-08 23:29 UTC (permalink / raw)
To: Alexander Kuleshov, Robin Holt
Cc: Andrew Morton, Mel Gorman, Michal Hocko, Vlastimil Babka,
David Rientjes, Joonsoo Kim, Yaowei Bai, Xishi Qiu,
Alexander Duyck, Kirill A . Shutemov, Johannes Weiner, linux-mm,
linux-kernel
On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
> This patch removes unused struct zone *z variable which is
> appeared in 86051ca5eaf5 (mm: fix usemap initialization)
I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
into a separate function).
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 9d666df..9bde098 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
> pg_data_t *pgdat = NODE_DATA(nid);
> unsigned long end_pfn = start_pfn + size;
> unsigned long pfn;
> - struct zone *z;
> unsigned long nr_initialised = 0;
>
> if (highest_memmap_pfn < end_pfn - 1)
> highest_memmap_pfn = end_pfn - 1;
>
> - z = &pgdat->node_zones[zone];
> for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> /*
> * There can be holes in boot-time mem_map[]s
> --
> 2.6.2.485.g1bc8fea
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable
2016-01-08 23:29 ` Kirill A. Shutemov
@ 2016-01-11 13:51 ` Vlastimil Babka
0 siblings, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2016-01-11 13:51 UTC (permalink / raw)
To: Kirill A. Shutemov, Alexander Kuleshov, Robin Holt
Cc: Andrew Morton, Mel Gorman, Michal Hocko, David Rientjes,
Joonsoo Kim, Yaowei Bai, Xishi Qiu, Alexander Duyck,
Kirill A . Shutemov, Johannes Weiner, linux-mm, linux-kernel
On 01/09/2016 12:29 AM, Kirill A. Shutemov wrote:
> On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
>> This patch removes unused struct zone *z variable which is
>> appeared in 86051ca5eaf5 (mm: fix usemap initialization)
>
> I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
> into a separate function).
Yeah but it's not a bug, so a tag like that would be just noise.
>>
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
>> ---
>> mm/page_alloc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 9d666df..9bde098 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
>> pg_data_t *pgdat = NODE_DATA(nid);
>> unsigned long end_pfn = start_pfn + size;
>> unsigned long pfn;
>> - struct zone *z;
>> unsigned long nr_initialised = 0;
>>
>> if (highest_memmap_pfn < end_pfn - 1)
>> highest_memmap_pfn = end_pfn - 1;
>>
>> - z = &pgdat->node_zones[zone];
>> for (pfn = start_pfn; pfn < end_pfn; pfn++) {
>> /*
>> * There can be holes in boot-time mem_map[]s
>> --
>> 2.6.2.485.g1bc8fea
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-11 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 7:59 [PATCH] mm/page_alloc: remove unused struct zone *z variable Alexander Kuleshov
2016-01-08 23:29 ` Kirill A. Shutemov
2016-01-11 13:51 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).