From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Andy Lutomirski <luto@amacapital.net>, Jan Kara <jack@suse.cz>,
yalin wang <yalin.wang2010@gmail.com>, Willy Tarreau <w@1wt.eu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-api@vger.kern, linux-mm@kvack.org
Subject: Re: [PATCH v6] fs: clear file privilege bits when mmap writing
Date: Sat, 9 Jan 2016 04:28:39 +0000 [thread overview]
Message-ID: <20160109042839.GA864@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160108232727.GA23490@www.outflux.net>
On Fri, Jan 08, 2016 at 03:27:27PM -0800, Kees Cook wrote:
> diff --git a/include/uapi/asm-generic/fcntl.h b/include/uapi/asm-generic/fcntl.h
> index e063effe0cc1..096c4b3afe6a 100644
> --- a/include/uapi/asm-generic/fcntl.h
> +++ b/include/uapi/asm-generic/fcntl.h
> @@ -88,6 +88,10 @@
> #define __O_TMPFILE 020000000
> #endif
>
> +#ifndef O_REMOVEPRIV
> +#define O_REMOVEPRIV 040000000
> +#endif
Hmm... Is that value always available? AFAICS, parisc has already grabbed
it (for __O_TMPFILE). On sparc it's taken by __O_SYNC, on alpha - O_PATH...
There's a reason why those definitions are not unconditional; some targets
have ABI shared with a preexisting Unix variant on the architecture in
question.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-09 4:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 23:27 [PATCH v6] fs: clear file privilege bits when mmap writing Kees Cook
2016-01-09 4:28 ` Al Viro [this message]
2016-01-10 15:48 ` Konstantin Khlebnikov
2016-01-10 19:30 ` Al Viro
2016-01-10 19:51 ` Konstantin Khlebnikov
2016-01-10 21:10 ` Al Viro
2016-01-10 22:30 ` Konstantin Khlebnikov
2016-01-11 19:38 ` Kees Cook
2016-01-11 22:39 ` Konstantin Khlebnikov
2016-01-11 22:45 ` Kees Cook
2016-01-11 23:16 ` Konstantin Khlebnikov
2016-01-11 23:19 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109042839.GA864@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kern \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=w@1wt.eu \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).