From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id 56538828F3 for ; Mon, 11 Jan 2016 05:51:09 -0500 (EST) Received: by mail-wm0-f54.google.com with SMTP id l65so205686806wmf.1 for ; Mon, 11 Jan 2016 02:51:09 -0800 (PST) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com. [2a00:1450:400c:c09::243]) by mx.google.com with ESMTPS id p13si22023736wmb.82.2016.01.11.02.51.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2016 02:51:08 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id l65so25658006wmf.3 for ; Mon, 11 Jan 2016 02:51:08 -0800 (PST) Date: Mon, 11 Jan 2016 11:51:05 +0100 From: Ingo Molnar Subject: Re: [RFC 09/13] x86/mm: Disable interrupts when flushing the TLB using CR3 Message-ID: <20160111105105.GB29448@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Andy Lutomirski , Oleg Nesterov , X86 ML , Dave Hansen , Borislav Petkov , Linux Kernel Mailing List , "linux-mm@kvack.org" , Brian Gerst * Linus Torvalds wrote: > >> Or is there some reason you wanted the odd flags version? If so, that > >> should be documented. > > > > What do you mean "odd"? > > It's odd because it makes no sense for non-pcid (christ, I wish Intel had just > called it "asid" instead, "pcid" always makes me react to "pci"), and I think it > would make more sense to pair up the pcid case with the invpcid rather than have > those preemption rules here. The naming is really painful, so a trivial suggestion: could we just name all the Linux side bits 'asid' or 'ctx_id' (even in x86 arch code) and only use 'PCID' nomenclature in the very lowest level code? I.e. rename pcid_live_cpus et al and most functions to the asid or ctx_id or asid naming scheme or so. That would hide most of the naming ugliness. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org