From: Andrew Morton <akpm@linux-foundation.org>
To: nimisolo <nimisolo@gmail.com>
Cc: kuleshovmail@gmail.com, penberg@kernel.org, tony.luck@intel.com,
mgorman@suse.de, tangchen@cn.fujitsu.com,
weiyang@linux.vnet.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: If nr_new is 0 just return
Date: Tue, 12 Jan 2016 14:40:20 -0800 [thread overview]
Message-ID: <20160112144020.db1cd77e97e41d5c48024c3c@linux-foundation.org> (raw)
In-Reply-To: <1452339220-3457-1-git-send-email-nimisolo@gmail.com>
On Sat, 9 Jan 2016 06:33:40 -0500 nimisolo <nimisolo@gmail.com> wrote:
> If nr_new is 0 which means there's no region would be added,
> so just return to the caller.
>
> ...
>
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -588,6 +588,9 @@ repeat:
> nid, flags);
> }
>
> + if (!nr_new)
> + return 0;
> +
> /*
> * If this was the first round, resize array and repeat for actual
> * insertions; otherwise, merge and return.
hm, why? Is there something actually wrong with the current code?
Under what circumstances does nr_new==0 actually happen? Is it a bug
in the caller?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-12 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 11:33 [PATCH] mm/memblock: If nr_new is 0 just return nimisolo
2016-01-12 22:40 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-09 11:30 nimisolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112144020.db1cd77e97e41d5c48024c3c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=nimisolo@gmail.com \
--cc=penberg@kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).