From: Johannes Weiner <hannes@cmpxchg.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: mhocko@kernel.org, vdavydov@virtuozzo.com,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, baiyaowei@cmss.chinamobile.com,
dan.j.williams@intel.com, tj@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
ajeet.y@samsung.com, pankaj.m@samsung.com,
Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH 1/1] mmzone: code cleanup for LRU stats.
Date: Mon, 18 Jan 2016 17:14:27 -0500 [thread overview]
Message-ID: <20160118221427.GA8657@cmpxchg.org> (raw)
In-Reply-To: <1453101492-37125-1-git-send-email-maninder1.s@samsung.com>
On Mon, Jan 18, 2016 at 12:48:12PM +0530, Maninder Singh wrote:
> Replacing hardcoded values with enum lru_stats for LRU stats.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
I don't think the code is hard to understand, it always says 'anon' or
'file' or similar for every context where it's important to understand
what the magic array index means.
And this patch makes the lines too long and unwieldy.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-01-18 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 7:18 [PATCH 1/1] mmzone: code cleanup for LRU stats Maninder Singh
2016-01-18 22:14 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118221427.GA8657@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=ajeet.y@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=cgroups@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maninder1.s@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=pankaj.m@samsung.com \
--cc=tj@kernel.org \
--cc=v.narang@samsung.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).