From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id 6A2186B0254 for ; Fri, 29 Jan 2016 06:05:46 -0500 (EST) Received: by mail-wm0-f54.google.com with SMTP id r129so63400145wmr.0 for ; Fri, 29 Jan 2016 03:05:46 -0800 (PST) Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com. [195.75.94.106]) by mx.google.com with ESMTPS id bj10si21460185wjc.110.2016.01.29.03.05.45 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 29 Jan 2016 03:05:45 -0800 (PST) Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 Jan 2016 11:05:44 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id EEB4B1B0804B for ; Fri, 29 Jan 2016 11:05:48 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0TB5e2Y2949590 for ; Fri, 29 Jan 2016 11:05:40 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0TA5f4e026405 for ; Fri, 29 Jan 2016 03:05:42 -0700 Date: Fri, 29 Jan 2016 12:05:37 +0100 From: Heiko Carstens Subject: Re: [linux-next:master 1875/2100] include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' Message-ID: <20160129110537.GB3896@osiris> References: <201601291512.vqk4lpvV%fengguang.wu@intel.com> <56AB3EEB.8090808@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56AB3EEB.8090808@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: kbuild test robot , Martin Schwidefsky , kbuild-all@01.org, linux-s390@vger.kernel.org, Stephen Rothwell , Andrew Morton , "linux-mm@kvack.org" , Peter Zijlstra On Fri, Jan 29, 2016 at 11:28:59AM +0100, Vlastimil Babka wrote: > On 01/29/2016 08:06 AM, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 735cfa51151aeae6df04074165aa36b42481df86 > > commit: e8bd33570a656979c09ce66a11ca8864fda8ad0c [1875/2100] mm, printk: introduce new format string for flags-fix > > config: s390-allyesconfig (attached as .config) > > reproduce: > > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout e8bd33570a656979c09ce66a11ca8864fda8ad0c > > # save the attached .config to linux build tree > > make.cross ARCH=s390 > > > > All errors (new ones prefixed by >>): > > > > In file included from include/linux/static_key.h:1:0, > > from include/linux/tracepoint-defs.h:11, > > from include/linux/mmdebug.h:6, > > from arch/s390/include/asm/cmpxchg.h:10, > > from arch/s390/include/asm/atomic.h:19, > > from include/linux/atomic.h:4, > > from include/linux/debug_locks.h:5, > > from include/linux/lockdep.h:23, > > from include/linux/hardirq.h:5, > > from include/linux/kvm_host.h:10, > > from arch/s390/kernel/asm-offsets.c:10: > > include/linux/jump_label.h: In function 'static_key_count': > >>> include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration] > > return atomic_read(&key->enabled); > > Sigh. > > I don't get it, there's "#include " in jump_label.h right before > it gets used. So, what implicit declaration? > > BTW, do you really need to use VM_BUG_ON() and thus include mmdebug.h in > arch/s390/include/asm/cmpxchg.h ? Is that assertion really related to VM? That's more or less copied over from x86 (and arm64 has it too). Probably because the only user used to be SLUB and the author has a strong memory management background :) However, I'd like to keep the sanity check. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org