From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Alexander Potapenko <glider@google.com>
Cc: kasan-dev@googlegroups.com, Christoph Lameter <cl@linux.com>,
linux-kernel@vger.kernel.org, Dmitriy Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
linux-mm@kvack.org, Andrey Konovalov <adech.fo@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
rostedt@goodmis.org
Subject: Re: [PATCH v1 5/8] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB
Date: Mon, 1 Feb 2016 11:55:31 +0900 [thread overview]
Message-ID: <20160201025530.GD32125@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <CAG_fn=VetOrSwqseiRwCFVr-nTTemczMixbbafgEJdqDRB4p7Q@mail.gmail.com>
On Thu, Jan 28, 2016 at 02:27:44PM +0100, Alexander Potapenko wrote:
> On Thu, Jan 28, 2016 at 1:51 PM, Alexander Potapenko <glider@google.com> wrote:
> >
> > On Jan 28, 2016 8:40 AM, "Joonsoo Kim" <iamjoonsoo.kim@lge.com> wrote:
> >>
> >> Hello,
> >>
> >> On Wed, Jan 27, 2016 at 07:25:10PM +0100, Alexander Potapenko wrote:
> >> > Stack depot will allow KASAN store allocation/deallocation stack traces
> >> > for memory chunks. The stack traces are stored in a hash table and
> >> > referenced by handles which reside in the kasan_alloc_meta and
> >> > kasan_free_meta structures in the allocated memory chunks.
> >>
> >> Looks really nice!
> >>
> >> Could it be more generalized to be used by other feature that need to
> >> store stack trace such as tracepoint or page owner?
> > Certainly yes, but see below.
> >
> >> If it could be, there is one more requirement.
> >> I understand the fact that entry is never removed from depot makes things
> >> very simpler, but, for general usecases, it's better to use reference
> >> count
> >> and allow to remove. Is it possible?
> > For our use case reference counting is not really necessary, and it would
> > introduce unwanted contention.
Okay.
> > There are two possible options, each having its advantages and drawbacks: we
> > can let the clients store the refcounters directly in their stacks (more
> > universal, but harder to use for the clients), or keep the counters in the
> > depot but add an API that does not change them (easier for the clients, but
> > potentially error-prone).
> > I'd say it's better to actually find at least one more user for the stack
> > depot in order to understand the requirements, and refactor the code after
> > that.
I re-think the page owner case and it also may not need refcount.
For now, just moving this stuff to /lib would be helpful for other future user.
BTW, is there any performance number? I guess that it could affect
the performance.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-02-01 2:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 18:25 [PATCH v1 0/8] SLAB support for KASAN Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 1/8] kasan: Change the behavior of kmalloc_large_oob_right test Alexander Potapenko
2016-02-02 5:34 ` Andrew Morton
2016-02-02 15:29 ` Andrey Ryabinin
2016-02-02 16:25 ` Alexander Potapenko
2016-02-15 14:05 ` Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 2/8] mm, kasan: SLAB support Alexander Potapenko
2016-01-28 7:44 ` Joonsoo Kim
2016-01-28 12:37 ` Alexander Potapenko
2016-01-28 13:29 ` Alexander Potapenko
2016-02-01 2:15 ` Joonsoo Kim
2016-02-18 12:58 ` Alexander Potapenko
2016-02-19 1:41 ` Joonsoo Kim
2016-02-19 12:57 ` Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 3/8] mm, kasan: Added GFP flags to KASAN API Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 4/8] arch, ftrace: For KASAN put hard/soft IRQ entries into separate sections Alexander Potapenko
2016-01-28 14:53 ` Steven Rostedt
2016-01-29 11:33 ` Alexander Potapenko
2016-01-29 11:59 ` Alexander Potapenko
2016-01-29 14:45 ` Steven Rostedt
2016-02-16 15:32 ` Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 5/8] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB Alexander Potapenko
2016-01-28 7:40 ` Joonsoo Kim
2016-01-28 12:51 ` Alexander Potapenko
2016-01-28 13:27 ` Alexander Potapenko
2016-02-01 2:55 ` Joonsoo Kim [this message]
2016-02-16 18:37 ` Alexander Potapenko
2016-02-17 18:29 ` Alexander Potapenko
2016-02-18 8:13 ` Joonsoo Kim
2016-02-18 15:01 ` Alexander Potapenko
2016-02-18 7:58 ` Joonsoo Kim
2016-01-27 18:25 ` [PATCH v1 6/8] kasan: Test fix: Warn if the UAF could not be detected in kmalloc_uaf2 Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 7/8] kasan: Changed kmalloc_large_oob_right, added kmalloc_pagealloc_oob_right Alexander Potapenko
2016-01-27 18:25 ` [PATCH v1 8/8] mm: kasan: Initial memory quarantine implementation Alexander Potapenko
2016-02-01 2:47 ` Joonsoo Kim
2016-02-18 14:06 ` Alexander Potapenko
2016-02-19 2:11 ` Joonsoo Kim
2016-02-19 9:19 ` Dmitry Vyukov
2016-02-19 15:43 ` Christoph Lameter
2016-02-23 7:23 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201025530.GD32125@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=adech.fo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).