* [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT
@ 2016-01-28 15:37 Vlastimil Babka
2016-02-02 8:41 ` Mel Gorman
0 siblings, 1 reply; 2+ messages in thread
From: Vlastimil Babka @ 2016-01-28 15:37 UTC (permalink / raw)
To: Mel Gorman, Andrew Morton; +Cc: linux-kernel, linux-mm, Vlastimil Babka
The description mentions kswapd threads, while the deferred struct page
initialization is actually done by one-off "pgdatinitX" threads. Fix the
description so that potentially users are not confused about pgdatinit threads
using CPU after boot instead of kswapd.
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
mm/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index 97a4e06b15c0..03cbfa072f42 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -624,7 +624,7 @@ config ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT
bool
config DEFERRED_STRUCT_PAGE_INIT
- bool "Defer initialisation of struct pages to kswapd"
+ bool "Defer initialisation of struct pages to kthreads"
default n
depends on ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT
depends on MEMORY_HOTPLUG
@@ -633,9 +633,10 @@ config DEFERRED_STRUCT_PAGE_INIT
single thread. On very large machines this can take a considerable
amount of time. If this option is set, large machines will bring up
a subset of memmap at boot and then initialise the rest in parallel
- when kswapd starts. This has a potential performance impact on
- processes running early in the lifetime of the systemm until kswapd
- finishes the initialisation.
+ by starting one-off "pgdatinitX" kernel thread for each node X. This
+ has a potential performance impact on processes running early in the
+ lifetime of the system until these kthreads finish the
+ initialisation.
config IDLE_PAGE_TRACKING
bool "Enable idle page tracking"
--
2.7.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT
2016-01-28 15:37 [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT Vlastimil Babka
@ 2016-02-02 8:41 ` Mel Gorman
0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2016-02-02 8:41 UTC (permalink / raw)
To: Vlastimil Babka; +Cc: Andrew Morton, linux-kernel, linux-mm
On Thu, Jan 28, 2016 at 04:37:28PM +0100, Vlastimil Babka wrote:
> The description mentions kswapd threads, while the deferred struct page
> initialization is actually done by one-off "pgdatinitX" threads. Fix the
> description so that potentially users are not confused about pgdatinit threads
> using CPU after boot instead of kswapd.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
This was an oversight when I moved to using kernel threads to do the
initialisation instead. Thanks for catching it.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-02 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 15:37 [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT Vlastimil Babka
2016-02-02 8:41 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).