From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Michal Hocko <mhocko@suse.cz>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] mm/workingset: do not forget to unlock page
Date: Thu, 4 Feb 2016 09:19:00 +0900 [thread overview]
Message-ID: <20160204001900.GB1861@swordfish> (raw)
In-Reply-To: <20160203220253.GA6859@cmpxchg.org>
On (02/03/16 17:02), Johannes Weiner wrote:
> On Wed, Feb 03, 2016 at 01:19:39PM -0800, Andrew Morton wrote:
> > Yup. I turned it into a fix against
> > mm-workingset-per-cgroup-cache-thrash-detection.patch, which is where
> > the bug was added. And I did the goto thing instead, so the final
> > result will be
> >
> > void workingset_activation(struct page *page)
> > {
> > struct lruvec *lruvec;
> >
> > lock_page_memcg(page);
> > /*
> > * Filter non-memcg pages here, e.g. unmap can call
> > * mark_page_accessed() on VDSO pages.
> > *
> > * XXX: See workingset_refault() - this should return
> > * root_mem_cgroup even for !CONFIG_MEMCG.
> > */
> > if (!mem_cgroup_disabled() && !page_memcg(page))
> > goto out;
> > lruvec = mem_cgroup_zone_lruvec(page_zone(page), page_memcg(page));
> > atomic_long_inc(&lruvec->inactive_age);
> > out:
> > unlock_page_memcg(page);
> > }
>
> LGTM, thank you.
Thanks!
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-02-04 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:58 [PATCH] mm/workingset: do not forget to unlock page Sergey Senozhatsky
2016-02-03 10:41 ` Sergey Senozhatsky
2016-02-03 16:24 ` Johannes Weiner
2016-02-03 21:19 ` Andrew Morton
2016-02-03 22:02 ` Johannes Weiner
2016-02-04 0:19 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204001900.GB1861@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=sergey.senozhatsky@gmail.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).