From: Michal Hocko <mhocko@kernel.org>
To: Nikolay Borisov <kernel@kyup.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: remove __GFP_NOFAIL is deprecated comment
Date: Thu, 25 Feb 2016 14:48:51 +0100 [thread overview]
Message-ID: <20160225134850.GA4204@dhcp22.suse.cz> (raw)
In-Reply-To: <56CEE72B.5040009@kyup.com>
On Thu 25-02-16 13:36:11, Nikolay Borisov wrote:
[...]
> > + /*
> > + * We most definitely don't want callers attempting to
> > + * allocate greater than order-1 page units with __GFP_NOFAIL.
> > + */
> > + WARN_ON_ONCE(unlikely(gfp_flags & __GFP_NOFAIL) && (order > 1));
>
> WARN_ON_ONCE already includes an unlikely in its definition:
> http://lxr.free-electrons.com/source/include/asm-generic/bug.h#L109
OK, I just wanted to keep the condition untouched but you are right the
unlikely can be removed.
> Reviewed-by: Nikolay Borisov <kernel@kyup.com>
Thanks!
---
next prev parent reply other threads:[~2016-02-25 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 10:43 [PATCH] mm: remove __GFP_NOFAIL is deprecated comment Michal Hocko
2016-02-25 11:36 ` Nikolay Borisov
2016-02-25 13:48 ` Michal Hocko [this message]
2016-03-07 14:57 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225134850.GA4204@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kernel@kyup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox