From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] mm/zsmalloc: add compact column to pool stat
Date: Mon, 29 Feb 2016 15:26:28 +0900 [thread overview]
Message-ID: <20160229062628.GA576@swordfish> (raw)
In-Reply-To: <20160229060247.GA3382@bbox>
Hello,
On (02/29/16 15:02), Minchan Kim wrote:
> On Sat, Feb 27, 2016 at 03:23:53PM +0900, Sergey Senozhatsky wrote:
> > Add a new column to pool stats, which will tell us class' zs_can_compact()
> > number, so it will be easier to analyze zsmalloc fragmentation.
>
> Just nitpick:
>
> Strictly speaking, zs_can_compact number is number of "ideal freeable page
> by compaction". How about using high level term in description rather than
> function name?
OK, makes sense.
> > At the moment, we have only numbers of FULL and ALMOST_EMPTY classes, but
> > they don't tell us how badly the class is fragmented internally.
> >
> > The new /sys/kernel/debug/zsmalloc/zramX/classes output look as follows:
> >
> > class size almost_full almost_empty obj_allocated obj_used pages_used pages_per_zspage compact
> > [..]
> > 12 224 0 2 146 5 8 4 4
> > 13 240 0 0 0 0 0 1 0
> > 14 256 1 13 1840 1672 115 1 10
> > 15 272 0 0 0 0 0 1 0
> > [..]
> > 49 816 0 3 745 735 149 1 2
> > 51 848 3 4 361 306 76 4 8
> > 52 864 12 14 378 268 81 3 21
> > 54 896 1 12 117 57 26 2 12
> > 57 944 0 0 0 0 0 3 0
> > [..]
> > Total 26 131 12709 10994 1071 134
> >
> > For example, from this particular output we can easily conclude that class-896
> > is heavily fragmented -- it occupies 26 pages, 12 can be freed by compaction.
>
> How about using "freeable" or something which could represent "freeable"?
> IMO, it's more strightforward for user.
OK. didn't want to put any long column name there, which would bloat the
output. will take a look.
> Other than that,
>
> Acked-by: Minchan Kim <minchan@kernel.org>
>
>
> Thanks for the nice job!
thanks.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-02-29 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 6:23 [PATCH] mm/zsmalloc: add compact column to pool stat Sergey Senozhatsky
2016-02-29 6:02 ` Minchan Kim
2016-02-29 6:26 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229062628.GA576@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).