From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Stancek <jstancek@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
n-horiguchi@ah.jp.nec.com, mike kravetz <mike.kravetz@oracle.com>,
hillf zj <hillf.zj@alibaba-inc.com>,
kirill shutemov <kirill.shutemov@linux.intel.com>,
dave hansen <dave.hansen@linux.intel.com>,
paul gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers
Date: Mon, 7 Mar 2016 16:03:59 -0800 [thread overview]
Message-ID: <20160307160359.c8cde2e7cc4a52234f212c0d@linux-foundation.org> (raw)
In-Reply-To: <983257005.5372143.1457165390827.JavaMail.zimbra@redhat.com>
On Sat, 5 Mar 2016 03:09:50 -0500 (EST) Jan Stancek <jstancek@redhat.com> wrote:
> > > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported,
> > > this value is propagated to userspace. EOPNOTSUPP is part of uapi
> > > and is widely supported by libc libraries.
> >
> > hm, what is the actual user-visible effect of this change? Does it fix
> > some misbehaviour?
> >
>
> It gives nicer message to user, rather than:
> # cat /proc/sys/vm/nr_hugepages
> cat: /proc/sys/vm/nr_hugepages: Unknown error 524
>
> And also LTP's proc01 test was failing because this ret code (524)
> was unexpected:
> proc01 1 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages: errno=???(524): Unknown error 524
> proc01 2 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_hugepages_mempolicy: errno=???(524): Unknown error 524
> proc01 3 TFAIL : proc01.c:396: read failed: /proc/sys/vm/nr_overcommit_hugepages: errno=???(524): Unknown error 524
>
Ah, OK, thanks. "Unknown error 524" is rather rude. I'll queue this
for 4.5.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-08 0:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:02 [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers Jan Stancek
2016-03-03 10:54 ` Kirill A. Shutemov
2016-03-03 23:05 ` Naoya Horiguchi
2016-03-04 21:38 ` Andrew Morton
2016-03-05 8:09 ` Jan Stancek
2016-03-08 0:03 ` Andrew Morton [this message]
2016-03-07 22:18 ` David Rientjes
2016-03-08 3:00 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307160359.c8cde2e7cc4a52234f212c0d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=jstancek@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).