From: Johannes Weiner <hannes@cmpxchg.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, mhocko@kernel.org, linux-mm@kvack.org,
rientjes@google.com, linux-kernel@vger.kernel.org,
mhocko@suse.com
Subject: Re: [PATCH 2/2] oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix
Date: Wed, 9 Mar 2016 17:48:29 -0500 [thread overview]
Message-ID: <20160309224829.GA5716@cmpxchg.org> (raw)
In-Reply-To: <201603100721.CDC86433.OMFOVOHSJFLFQt@I-love.SAKURA.ne.jp>
On Thu, Mar 10, 2016 at 07:21:58AM +0900, Tetsuo Handa wrote:
> Andrew Morton wrote:
> > I found the below patch lying around but I didn't queue it properly.
> > Is it legit?
>
> I think that patch wants patch description updated.
> Not testing pure noise, but causing possible livelock.
> http://lkml.kernel.org/r/20160217143917.GP29196@dhcp22.suse.cz
Sorry, I completely missed that. We're drowning in OOM killer fixes!
However, I disagree with your changelog. The scenario you describe is
real, but that the hung task is exiting is also noise. The underlying
problem is that the OOM victim is hung. Instead of OOM_SCAN_ABORT, the
OOM killer could also select some other non-exiting task that has the
mmap_sem held for reading. This patch doesn't fix that bug.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-09 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 13:12 [PATCH -mm 0/2] oom_reaper: missing parts Michal Hocko
2016-03-08 13:12 ` [PATCH 1/2] mm-oom_reaper-report-success-failure-fix-fix Michal Hocko
2016-03-08 13:12 ` [PATCH 2/2] oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix Michal Hocko
2016-03-09 21:21 ` Andrew Morton
2016-03-09 22:21 ` Tetsuo Handa
2016-03-09 22:48 ` Johannes Weiner [this message]
2016-03-09 23:08 ` Andrew Morton
2016-03-10 0:45 ` Johannes Weiner
2016-03-10 11:17 ` [PATCH 2/2]oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix Tetsuo Handa
2016-03-09 22:30 ` [PATCH 2/2] oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix Johannes Weiner
2016-03-08 13:18 ` [PATCH -mm 0/2] oom_reaper: missing parts Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309224829.GA5716@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).