From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com [209.85.161.170]) by kanga.kvack.org (Postfix) with ESMTP id 917A66B0005 for ; Sun, 13 Mar 2016 17:30:11 -0400 (EDT) Received: by mail-yw0-f170.google.com with SMTP id h129so146952018ywb.1 for ; Sun, 13 Mar 2016 14:30:11 -0700 (PDT) Received: from imap.thunk.org (imap.thunk.org. [2600:3c02::f03c:91ff:fe96:be03]) by mx.google.com with ESMTPS id u22si6403338ywg.210.2016.03.13.14.30.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Mar 2016 14:30:10 -0700 (PDT) Date: Sun, 13 Mar 2016 17:30:06 -0400 From: Theodore Ts'o Subject: Re: [PATCH RFC] ext4: use __GFP_NOFAIL in ext4_free_blocks() Message-ID: <20160313213006.GG29218@thunk.org> References: <20160224170912.2195.8153.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160224170912.2195.8153.stgit@buzz> Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dmitry Monakhov , Johannes Weiner , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org On Wed, Feb 24, 2016 at 08:09:12PM +0300, Konstantin Khlebnikov wrote: > This might be unexpected but pages allocated for sbi->s_buddy_cache are > charged to current memory cgroup. So, GFP_NOFS allocation could fail if > current task has been killed by OOM or if current memory cgroup has no > free memory left. Block allocator cannot handle such failures here yet. > > Signed-off-by: Konstantin Khlebnikov Thanks, applied. - Ted -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org