From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 64B056B0005 for ; Wed, 30 Mar 2016 02:56:53 -0400 (EDT) Received: by mail-pa0-f48.google.com with SMTP id fe3so33084699pab.1 for ; Tue, 29 Mar 2016 23:56:53 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id f22si4321380pfj.46.2016.03.29.23.56.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Mar 2016 23:56:52 -0700 (PDT) Date: Tue, 29 Mar 2016 23:56:46 -0700 From: Christoph Hellwig Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io Message-ID: <20160330065646.GA13123@infradead.org> References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> <20160330063415.GA2132@infradead.org> <1459320877.4102.3.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459320877.4102.3.camel@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Vishal Verma Cc: Christoph Hellwig , Vishal Verma , linux-block@vger.kernel.org, Jan Kara , linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Jens Axboe , linux-mm@kvack.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Al Viro On Wed, Mar 30, 2016 at 12:54:37AM -0600, Vishal Verma wrote: > On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote: > > Hi Vishal, > > > > still NAK to calling the direct I/O code directly from the dax code. > > Hm, I thought this was what you meant -- do the fallback/retry attempts > at the callers of dax_do_io instead of the new dax wrapper function.. > Did I misunderstand you? Sorry, it is. I misread fs/block_dev.c as fs/dax.c before my first coffee this morning. I'll properly review the series in the afternoon.. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org