From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by kanga.kvack.org (Postfix) with ESMTP id 7A7656B025E for ; Fri, 8 Apr 2016 16:05:16 -0400 (EDT) Received: by mail-pf0-f173.google.com with SMTP id n1so81692071pfn.2 for ; Fri, 08 Apr 2016 13:05:16 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id p28si2456581pfi.167.2016.04.08.13.05.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2016 13:05:15 -0700 (PDT) Date: Fri, 8 Apr 2016 13:05:14 -0700 From: Greg KH Subject: Re: [PATCH] lib: lz4: fixed zram with lz4 on big endian machines Message-ID: <20160408200514.GA20114@kroah.com> References: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com> <20160408165051.GB16346@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Rui Salvaterra Cc: Chanho Min , Sergey Senozhatsky , eunb.song@samsung.com, linux-kernel@vger.kernel.org, kyungsik.lee@lge.com, stable@vger.kernel.org, minchan@kernel.org, sergey.senozhatsky@gmail.com, linux-mm@kvack.org On Fri, Apr 08, 2016 at 08:51:17PM +0100, Rui Salvaterra wrote: > > On 8 Apr 2016 17:50, "Greg KH" wrote: > > > > On Fri, Apr 08, 2016 at 04:23:24PM +0100, Rui Salvaterra wrote: > > > Based on Sergey's test patch [1], this fixes zram with lz4 compression on > big endian cpus. Tested on ppc64 with no regression on x86_64. > > > > Please wrap your text at 72 columns in a changelog comment. > > > > > > > > [1] http://marc.info/?l=linux-kernel&m=145994470805853&w=4 > > > > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Rui Salvaterra > > > > Please attribute Sergey here in the signed-off-by area with a > > "Suggested-by:" type mark > > > > > --- > > > lib/lz4/lz4defs.h | 29 +++++++++++++++-------------- > > > 1 file changed, 15 insertions(+), 14 deletions(-) > > > > > > diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h > > > index abcecdc..a98c08c 100644 > > > --- a/lib/lz4/lz4defs.h > > > +++ b/lib/lz4/lz4defs.h > > > @@ -11,8 +11,7 @@ > > > /* > > > * Detects 64 bits mode > > > */ > > > -#if (defined(__x86_64__) || defined(__x86_64) || defined(__amd64__) \ > > > - || defined(__ppc64__) || defined(__LP64__)) > > > +#if defined(CONFIG_64BIT) > > > > This patch seems to do two different things, clean up the #if tests, and > > change the endian of some calls. Can you break this up into 2 different > > patches? > > > > thanks, > > > > greg k-h > > Hi Greg, > > Thanks for the review (and patience). The 64-bit #if test is actually part of > the fix, since __ppc64__ isn't defined anywhere and we'd fall into the 32-bit > definitions for ppc64. I can send the other one separately, for sure. I'll do a > v2 tomorrow. Ah, well document that please, it was not obvious at all that this was required. thanks, greg k-h- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org