From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Michal Hocko <mhocko@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
"Odzioba, Lukasz" <lukasz.odzioba@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Shutemov, Kirill" <kirill.shutemov@intel.com>,
"Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com>
Subject: Re: mm: pages are not freed from lru_add_pvecs after process termination
Date: Tue, 3 May 2016 13:07:48 +0300 [thread overview]
Message-ID: <20160503100748.GA31787@node.shutemov.name> (raw)
In-Reply-To: <20160503073757.GA28046@dhcp22.suse.cz>
On Tue, May 03, 2016 at 09:37:57AM +0200, Michal Hocko wrote:
> On Mon 02-05-16 19:02:50, Kirill A. Shutemov wrote:
> > On Mon, May 02, 2016 at 08:49:03AM -0700, Dave Hansen wrote:
> > > On 05/02/2016 08:01 AM, Kirill A. Shutemov wrote:
> > > > On Mon, May 02, 2016 at 04:39:35PM +0200, Vlastimil Babka wrote:
> > > >> On 04/27/2016 07:11 PM, Dave Hansen wrote:
> > > >>> 6. Perhaps don't use the LRU pagevecs for large pages. It limits the
> > > >>> severity of the problem.
> > > >>
> > > >> I think that makes sense. Being large already amortizes the cost per base
> > > >> page much more than pagevecs do (512 vs ~22 pages?).
> > > >
> > > > We try to do this already, don't we? Any spefic case where we have THPs on
> > > > pagevecs?
> > >
> > > Lukas was hitting this on a RHEL 7 era kernel. In his kernel at least,
> > > I'm pretty sure THP's were ending up on pagevecs. Are you saying you
> > > don't think we're doing that any more?
> >
> > As Vlastimil pointed, we do. It need to be fixed, I think.
>
> It seems that offloading the draining to the vmstat context doesn't look
> terribly bad. Don't we rather want to go that way?
Maybe. My knowledge about lru cache is limited.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-03 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 17:01 mm: pages are not freed from lru_add_pvecs after process termination Odzioba, Lukasz
2016-04-27 17:11 ` Dave Hansen
2016-04-28 14:37 ` Michal Hocko
2016-05-02 13:00 ` Michal Hocko
2016-05-04 19:41 ` Odzioba, Lukasz
2016-05-04 20:16 ` Dave Hansen
2016-05-04 20:36 ` Michal Hocko
2016-05-05 7:21 ` Michal Hocko
2016-05-05 17:25 ` Odzioba, Lukasz
2016-05-11 7:38 ` Michal Hocko
2016-05-06 15:10 ` Odzioba, Lukasz
2016-05-06 16:04 ` Dave Hansen
2016-05-11 7:53 ` Michal Hocko
2016-05-13 11:29 ` Vlastimil Babka
2016-05-13 12:05 ` Odzioba, Lukasz
2016-06-07 9:02 ` Odzioba, Lukasz
2016-06-07 11:19 ` Michal Hocko
2016-06-08 8:51 ` Odzioba, Lukasz
2016-05-02 14:39 ` Vlastimil Babka
2016-05-02 15:01 ` Kirill A. Shutemov
2016-05-02 15:13 ` Vlastimil Babka
2016-05-02 15:49 ` Dave Hansen
2016-05-02 16:02 ` Kirill A. Shutemov
2016-05-03 7:37 ` Michal Hocko
2016-05-03 10:07 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503100748.GA31787@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukasz.anaczkowski@intel.com \
--cc=lukasz.odzioba@intel.com \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).