linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@linux.intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix
Date: Tue, 3 May 2016 14:28:57 -0600	[thread overview]
Message-ID: <20160503202857.GA3997@linux.intel.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1605012108490.1166@eggly.anvils>

On Sun, May 01, 2016 at 09:13:18PM -0700, Hugh Dickins wrote:
> radix_tree_locate_item() is often returning the wrong index, causing
> swapoff of shmem to hang because it cannot find the swap entry there.
> __locate()'s use of base is bogus, it adds an offset twice into index.
> 
> Signed-off-by: Hugh Dickins <hughd@google.com>

Thank you for the fix!

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2016-05-03 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02  4:13 [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix Hugh Dickins
2016-05-03 20:27 ` [PATCH] radix-tree: add test for radix_tree_locate_item() Ross Zwisler
2016-05-03 20:28 ` Ross Zwisler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503202857.GA3997@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).