From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f70.google.com (mail-pa0-f70.google.com [209.85.220.70]) by kanga.kvack.org (Postfix) with ESMTP id F3E586B0005 for ; Sun, 8 May 2016 04:52:08 -0400 (EDT) Received: by mail-pa0-f70.google.com with SMTP id zy2so258214119pac.1 for ; Sun, 08 May 2016 01:52:08 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id z1si30780673pax.146.2016.05.08.01.52.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 May 2016 01:52:08 -0700 (PDT) Date: Sun, 8 May 2016 01:52:03 -0700 From: Christoph Hellwig Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Message-ID: <20160508085203.GA10160@infradead.org> References: <1462571591-3361-1-git-send-email-vishal.l.verma@intel.com> <1462571591-3361-4-git-send-email-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462571591-3361-4-git-send-email-vishal.l.verma@intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vishal Verma Cc: linux-nvdimm@ml01.01.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Ross Zwisler , Dan Williams , Dave Chinner , Jan Kara , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Moyer , Boaz Harrosh On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote: > From: Matthew Wilcox > > dax_clear_sectors() cannot handle poisoned blocks. These must be > zeroed using the BIO interface instead. Convert ext2 and XFS to use > only sb_issue_zerout(). > > Signed-off-by: Matthew Wilcox > [vishal: Also remove the dax_clear_sectors function entirely] > Signed-off-by: Vishal Verma Just to make sure: the existing sb_issue_zerout as in 4.6-rc is already doing the right thing for DAX? I've got a pending patchset for XFS that introduces another dax_clear_sectors users, but if it's already safe to use blkdev_issue_zeroout I can switch to that and avoid the merge conflict. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org