From: Mike Marciniszyn <mike.marciniszyn@intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [1/1] mm: thp: calculate the mapcount correctly for THP pages during WP faults
Date: Wed, 11 May 2016 17:26:16 -0400 [thread overview]
Message-ID: <20160511212552.GA20578@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <1462908082-12657-1-git-send-email-aarcange@redhat.com>
>
>Reviewed-by: "Kirill A. Shutemov" <kirill@shutemov.name>
>Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
>
Our RDMA tests are seeing an issue with memory locking that bisects to
commit 61f5d698cc97 ("mm: re-enable THP").
The test program registers two rather large MRs (512M) and RDMA writes
data to a passive peer using the first and RDMA reads it back into the
second MR and compares that data. The sizes are chosen randomly between
0 and 1024 bytes.
The test will get through a few (<= 4 iterations) and then gets a compare error.
Tracing indicates the kernel logical addresses associated with the individual
pages at registration ARE correct , the data in the "RDMA read response only"
packets ARE correct.
The a??corruptiona?? occurs when the packet crosse two pages that are not
physically contiguous. The second page reads back as zero in the program.
It looks like the user VA at the point of the compare error no longer points
to the same physical address as was registered.
This patch totally resolves the issue!
Tested-by: Mike Marciniszyn <mike.marciniszy@intel.com>
Tested-by: Josh Collier <josh.d.collier@intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-11 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 15:03 [PATCH 0/3] mm: thp: mapcount updates Andrea Arcangeli
2016-05-06 15:03 ` [PATCH 1/3] mm: thp: calculate the mapcount correctly for THP pages during WP faults Andrea Arcangeli
2016-05-06 22:10 ` Alex Williamson
2016-05-09 22:26 ` Andrew Morton
2016-05-10 19:21 ` [PATCH 1/1] " Andrea Arcangeli
2016-05-11 21:26 ` Mike Marciniszyn [this message]
2016-05-12 16:32 ` Andrea Arcangeli
2016-05-12 18:48 ` [1/1] " Mike Marciniszyn
2016-05-06 15:03 ` [PATCH 2/3] mm: thp: microoptimize compound_mapcount() Andrea Arcangeli
2016-05-06 17:33 ` Kirill A. Shutemov
2016-05-06 15:04 ` [PATCH 3/3] mm: thp: split_huge_pmd_address() comment improvement Andrea Arcangeli
2016-05-06 17:33 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511212552.GA20578@phlsvsds.ph.intel.com \
--to=mike.marciniszyn@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).