From: Christoph Hellwig <hch@infradead.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
boris.brezillon@free-electrons.com,
maxime.ripard@free-electrons.com, david@sigma-star.at,
david@fromorbit.com, dedekind1@gmail.com, alex@nextthing.co,
akpm@linux-foundation.org, sasha.levin@oracle.com,
iamjoonsoo.kim@lge.com, rvaswani@codeaurora.org,
tony.luck@intel.com, shailendra.capricorn@gmail.com,
kirill.shutemov@linux.intel.com, hch@infradead.org,
hughd@google.com, mgorman@techsingularity.net, vbabka@suse.cz
Subject: Re: UBIFS and page migration (take 3)
Date: Thu, 12 May 2016 04:49:48 -0700 [thread overview]
Message-ID: <20160512114948.GA25113@infradead.org> (raw)
In-Reply-To: <1462974823-3168-1-git-send-email-richard@nod.at>
Hi Richard,
the series looks fine to me, but it fails to address the root cause:
that we have an inherently dangerous default for ->migratepage that
assumes that file systems are implemented a certain way. I think the
series should also grow a third patch to remove the default and just
wire it up for the known good file systems, although we'd need some
input on what known good is.
Any idea what filesystems do get regular testing with code that's using
CMA? A good approximation might be those that use the bufer_head
based aops from fs/buffer.c
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-12 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 13:53 UBIFS and page migration (take 3) Richard Weinberger
2016-05-11 13:53 ` [PATCH 1/2] mm: Export migrate_page_move_mapping and migrate_page_copy Richard Weinberger
2016-05-11 13:53 ` [PATCH 2/2] UBIFS: Implement ->migratepage() Richard Weinberger
2016-05-12 10:47 ` Richard Weinberger
2016-05-12 11:49 ` Christoph Hellwig [this message]
2016-05-16 12:44 ` UBIFS and page migration (take 3) Richard Weinberger
2016-05-16 13:03 ` Vlastimil Babka
2016-05-17 9:12 ` Christoph Hellwig
2016-05-17 11:27 ` Richard Weinberger
2016-05-18 9:03 ` Richard Weinberger
2016-05-17 9:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512114948.GA25113@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex@nextthing.co \
--cc=boris.brezillon@free-electrons.com \
--cc=david@fromorbit.com \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mgorman@techsingularity.net \
--cc=richard@nod.at \
--cc=rvaswani@codeaurora.org \
--cc=sasha.levin@oracle.com \
--cc=shailendra.capricorn@gmail.com \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).