From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zram: introduce per-device debug_stat sysfs node
Date: Sat, 14 May 2016 12:37:07 +0900 [thread overview]
Message-ID: <20160514033707.GA15615@swordfish> (raw)
In-Reply-To: <20160513230546.GA26763@bbox>
Hello Minchan,
On (05/14/16 08:05), Minchan Kim wrote:
[..]
> > recompress:
> > compress
> > handle = zs_malloc FAST PATH
> >
> > if (!handle) {
> > release stream
> > handle = zs_malloc SLOW PATH
> >
> > << my patch accounts SLOW PATH here >>
> >
> > if (handle) {
> > num_recompress++ << NEW version accounts it here, only it was OK >>
> > goto recompress;
> > }
> >
> > goto err; << SLOW PATH is not accounted if SLOW PATH was unsuccessful
> > }
> >
>
> I got your point. You want to account every slow path and change
> the naming from num_recompress to something to show that slow path.
yes :)
> Sorry for catching your point too late. And I absolutely agree with you.
> I want to name it with 'writestall' like MM's allocstall. :)
no problem. 'writestall' is really good, that's the word I was looking
for.
> Now I saw you sent new version but I like your suggestion more.
>
> I will send new verion by hand :)
> Thanks for the arguing. It was worth!
oh, thanks!
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-14 2:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 13:45 [PATCH] zram: introduce per-device debug_stat sysfs node Sergey Senozhatsky
2016-05-12 23:41 ` Minchan Kim
2016-05-13 1:09 ` Sergey Senozhatsky
2016-05-13 6:23 ` Minchan Kim
2016-05-13 6:58 ` Sergey Senozhatsky
2016-05-13 7:05 ` Sergey Senozhatsky
2016-05-13 7:20 ` Minchan Kim
2016-05-13 7:41 ` Sergey Senozhatsky
2016-05-13 8:06 ` Sergey Senozhatsky
2016-05-13 23:05 ` Minchan Kim
2016-05-14 3:37 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160514033707.GA15615@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).