From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v5 07/12] zsmalloc: factor page chain functionality out
Date: Tue, 17 May 2016 10:02:22 +0900 [thread overview]
Message-ID: <20160517010222.GA31335@bbox> (raw)
In-Reply-To: <20160516021420.GC504@swordfish>
On Mon, May 16, 2016 at 11:14:20AM +0900, Sergey Senozhatsky wrote:
> On (05/09/16 11:20), Minchan Kim wrote:
> > For page migration, we need to create page chain of zspage dynamically
> > so this patch factors it out from alloc_zspage.
> >
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Thanks!
>
> [..]
> > + page = alloc_page(flags);
> > + if (!page) {
> > + while (--i >= 0)
> > + __free_page(pages[i]);
>
> put_page() ?
>
> a minor nit, put_page() here probably will be in alignment
> with __free_zspage(), which does put_page().
Normally, we use put_page in case that someone can grab a referece of
the page so we cannot free the page. Otherwise, alloc_page and
__free_page is more straight to me code readability POV.
>
> -ss
>
> > + return NULL;
> > + }
> > + pages[i] = page;
> > }
> >
> > + create_page_chain(pages, class->pages_per_zspage);
> > + first_page = pages[0];
> > + init_zspage(class, first_page);
> > +
> > return first_page;
> > }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-17 1:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 2:20 [PATCH v5 00/13] Support non-lru page migration Minchan Kim
2016-05-09 2:20 ` [PATCH v5 01/12] mm: use put_page to free page instead of putback_lru_page Minchan Kim
2016-05-09 2:20 ` [PATCH v5 02/12] mm: migrate: support non-lru movable page migration Minchan Kim
2016-05-16 7:04 ` Sergey Senozhatsky
2016-05-17 1:16 ` Minchan Kim
2016-05-16 7:17 ` Sergey Senozhatsky
2016-05-17 1:18 ` Minchan Kim
2016-05-17 1:30 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 03/12] mm: balloon: use general non-lru movable page feature Minchan Kim
2016-05-16 19:16 ` kbuild test robot
2016-05-09 2:20 ` [PATCH v5 04/12] zsmalloc: keep max_object in size_class Minchan Kim
2016-05-09 2:20 ` [PATCH v5 05/12] zsmalloc: use bit_spin_lock Minchan Kim
2016-05-16 1:17 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 06/12] zsmalloc: use accessor Minchan Kim
2016-05-16 1:48 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 07/12] zsmalloc: factor page chain functionality out Minchan Kim
2016-05-16 2:14 ` Sergey Senozhatsky
2016-05-17 1:02 ` Minchan Kim [this message]
2016-05-09 2:20 ` [PATCH v5 08/12] zsmalloc: introduce zspage structure Minchan Kim
2016-05-16 3:09 ` Sergey Senozhatsky
2016-05-17 1:14 ` Minchan Kim
2016-05-17 1:27 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 09/12] zsmalloc: separate free_zspage from putback_zspage Minchan Kim
2016-05-16 3:15 ` Sergey Senozhatsky
2016-05-09 2:20 ` [PATCH v5 10/12] zsmalloc: use freeobj for index Minchan Kim
2016-05-09 2:20 ` [PATCH v5 11/12] zsmalloc: page migration support Minchan Kim
2016-05-16 19:33 ` kbuild test robot
2016-05-09 2:20 ` [PATCH v5 12/12] zram: use __GFP_MOVABLE for memory allocation Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517010222.GA31335@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).