From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper
Date: Tue, 31 May 2016 23:25:17 +0200 [thread overview]
Message-ID: <20160531212517.GA26582@redhat.com> (raw)
In-Reply-To: <1464679423-30218-1-git-send-email-mhocko@kernel.org>
On 05/31, Michal Hocko wrote:
>
> @@ -636,10 +634,7 @@ void try_oom_reaper(struct task_struct *tsk)
> * If the task is exiting make sure the whole thread group
> * is exiting and cannot acces mm anymore.
> */
> - spin_lock_irq(&p->sighand->siglock);
> - exiting = signal_group_exit(p->signal);
> - spin_unlock_irq(&p->sighand->siglock);
> - if (exiting)
> + if (signal_group_exit(p->signal))
> continue;
Yes, thanks Michal. signal_group_exit() is not really right too (coredump)
but this is not that important and you are going to rework this code anyway.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-31 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 7:23 [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper Michal Hocko
2016-05-31 21:25 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531212517.GA26582@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).