linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h
Date: Thu, 2 Jun 2016 16:10:17 +0900	[thread overview]
Message-ID: <20160602071017.GA439@swordfish> (raw)
In-Reply-To: <94e9f6fee719fcaa91ee5767a9ad64658c6f5237.1464847139.git.geliangtang@gmail.com>

On (06/02/16 14:15), Geliang Tang wrote:
> Remove unused header cpumask.h from mm/zsmalloc.c.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  mm/zsmalloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index b6d4f25..a93327e 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -57,7 +57,6 @@
>  #include <linux/slab.h>
>  #include <asm/tlbflush.h>
>  #include <asm/pgtable.h>
> -#include <linux/cpumask.h>
>  #include <linux/cpu.h>
>  #include <linux/vmalloc.h>
>  #include <linux/preempt.h>

NAK. I don't think it's "unused".

zs_register_cpu_notifier()
	for_each_online_cpu()


which is coming from include/linux/cpumask.h

#define for_each_online_cpu(cpu)   for_each_cpu((cpu), cpu_online_mask)

	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-06-02  7:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  6:15 [PATCH 1/4] mm/init-mm: remove unused header cpumask.h Geliang Tang
2016-06-02  6:15 ` [PATCH 2/4] mm: kmemleak: " Geliang Tang
2016-06-02  6:15   ` [PATCH 3/4] mm/vmstat: " Geliang Tang
2016-06-02  6:15     ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
2016-06-02  7:10       ` Sergey Senozhatsky [this message]
2016-06-02  6:44     ` [PATCH 3/4] mm/vmstat: " Michal Hocko
2016-06-02 13:46     ` Christoph Lameter
2016-06-02  9:32   ` [PATCH 2/4] mm: kmemleak: " Catalin Marinas
2016-06-02 10:10     ` Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602071017.GA439@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=geliangtang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).