From: Minchan Kim <minchan@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <andi@firstfloor.org>, Michal Hocko <mhocko@suse.cz>,
Tim Chen <tim.c.chen@linux.intel.com>,
kernel-team@fb.com
Subject: Re: [PATCH 10/10] mm: balance LRU lists based on relative thrashing
Date: Wed, 15 Jun 2016 11:23:41 +0900 [thread overview]
Message-ID: <20160615022341.GF17127@bbox> (raw)
In-Reply-To: <20160613155231.GB30642@cmpxchg.org>
On Mon, Jun 13, 2016 at 11:52:31AM -0400, Johannes Weiner wrote:
> On Fri, Jun 10, 2016 at 11:19:35AM +0900, Minchan Kim wrote:
> > On Mon, Jun 06, 2016 at 03:48:36PM -0400, Johannes Weiner wrote:
> > > @@ -79,6 +79,7 @@ enum pageflags {
> > > PG_dirty,
> > > PG_lru,
> > > PG_active,
> > > + PG_workingset,
> >
> > I think PG_workingset might be a good flag in the future, core MM might
> > utilize it to optimize something so I hope it supports for 32bit, too.
> >
> > A usecase with PG_workingset in old was cleancache. A few year ago,
> > Dan tried it to only cache activated page from page cache to cleancache,
> > IIRC. As well, many system using zram(i.e., fast swap) are still 32 bit
> > architecture.
> >
> > Just an idea. we might be able to move less important flag(i.e., enabled
> > in specific configuration, for example, PG_hwpoison or PG_uncached) in 32bit
> > to page_extra to avoid allocate extra memory space and charge the bit as
> > PG_workingset. :)
>
> Yeah, I do think it should be a core flag. We have the space for it.
>
> > Other concern about PG_workingset is naming. For file-backed pages, it's
> > good because file-backed pages started from inactive's head and promoted
> > active LRU once two touch so it's likely to be workingset. However,
> > for anonymous page, it starts from active list so every anonymous page
> > has PG_workingset while mlocked pages cannot have a chance to have it.
> > It wouldn't matter in eclaim POV but if we would use PG_workingset as
> > indicator to identify real workingset page, it might be confused.
> > Maybe, We could mark mlocked pages as workingset unconditionally.
>
> Hm I'm not sure it matters. Technically we don't have to set it on
> anon, but since it's otherwise unused anyway, it's nice to set it to
> reinforce the notion that anon is currently always workingset.
When I read your description firstly, I thought the flag for anon page
is set on only swapin but now I feel you want to set it for all of
anonymous page but it has several holes like mlocked pages, shmem pages
and THP and you want to fix it in THP case only.
Hm, What's the rule?
It's not consistent and confusing to me. :(
I think it would be better that PageWorkingset function should return
true in case of PG_swapbacked set if we want to consider all pages of
anonymous LRU PG_workingset which is more clear, not error-prone, IMHO.
Another question:
Do we want to retain [1]?
This patch motivates from swap IO could be much faster than file IO
so that it would be natural if we rely on refaulting feedback rather
than forcing evicting file cache?
[1] e9868505987a, mm,vmscan: only evict file pages when we have plenty?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-15 2:23 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 19:48 [PATCH 00/10] mm: balance LRU lists based on relative thrashing Johannes Weiner
2016-06-06 19:48 ` [PATCH 01/10] mm: allow swappiness that prefers anon over file Johannes Weiner
2016-06-07 0:25 ` Minchan Kim
2016-06-07 14:18 ` Johannes Weiner
2016-06-08 0:06 ` Minchan Kim
2016-06-08 15:58 ` Johannes Weiner
2016-06-09 1:01 ` Minchan Kim
2016-06-09 13:32 ` Johannes Weiner
2016-06-06 19:48 ` [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Johannes Weiner
2016-06-06 21:32 ` Rik van Riel
2016-06-07 9:07 ` Michal Hocko
2016-06-08 7:14 ` Minchan Kim
2016-06-06 19:48 ` [PATCH 03/10] mm: fold and remove lru_cache_add_anon() and lru_cache_add_file() Johannes Weiner
2016-06-06 21:33 ` Rik van Riel
2016-06-07 9:12 ` Michal Hocko
2016-06-08 7:24 ` Minchan Kim
2016-06-06 19:48 ` [PATCH 04/10] mm: fix LRU balancing effect of new transparent huge pages Johannes Weiner
2016-06-06 21:36 ` Rik van Riel
2016-06-07 9:19 ` Michal Hocko
2016-06-08 7:28 ` Minchan Kim
2016-06-06 19:48 ` [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation Johannes Weiner
2016-06-06 21:56 ` Rik van Riel
2016-06-06 22:15 ` Johannes Weiner
2016-06-07 1:11 ` Rik van Riel
2016-06-07 13:57 ` Johannes Weiner
2016-06-07 9:26 ` Michal Hocko
2016-06-07 14:06 ` Johannes Weiner
2016-06-07 9:49 ` Michal Hocko
2016-06-08 7:39 ` Minchan Kim
2016-06-08 16:02 ` Johannes Weiner
2016-06-06 19:48 ` [PATCH 06/10] mm: remove unnecessary use-once cache bias from LRU balancing Johannes Weiner
2016-06-07 2:20 ` Rik van Riel
2016-06-07 14:11 ` Johannes Weiner
2016-06-08 8:03 ` Minchan Kim
2016-06-08 12:31 ` Michal Hocko
2016-06-06 19:48 ` [PATCH 07/10] mm: base LRU balancing on an explicit cost model Johannes Weiner
2016-06-06 19:13 ` kbuild test robot
2016-06-07 2:34 ` Rik van Riel
2016-06-07 14:12 ` Johannes Weiner
2016-06-08 8:14 ` Minchan Kim
2016-06-08 16:06 ` Johannes Weiner
2016-06-08 12:51 ` Michal Hocko
2016-06-08 16:16 ` Johannes Weiner
2016-06-09 12:18 ` Michal Hocko
2016-06-09 13:33 ` Johannes Weiner
2016-06-06 19:48 ` [PATCH 08/10] mm: deactivations shouldn't bias the LRU balance Johannes Weiner
2016-06-08 8:15 ` Minchan Kim
2016-06-08 12:57 ` Michal Hocko
2016-06-06 19:48 ` [PATCH 09/10] mm: only count actual rotations as LRU reclaim cost Johannes Weiner
2016-06-08 8:19 ` Minchan Kim
2016-06-08 13:18 ` Michal Hocko
2016-06-06 19:48 ` [PATCH 10/10] mm: balance LRU lists based on relative thrashing Johannes Weiner
2016-06-06 19:22 ` kbuild test robot
2016-06-06 23:50 ` Tim Chen
2016-06-07 16:23 ` Johannes Weiner
2016-06-07 19:56 ` Tim Chen
2016-06-08 13:58 ` Michal Hocko
2016-06-10 2:19 ` Minchan Kim
2016-06-13 15:52 ` Johannes Weiner
2016-06-15 2:23 ` Minchan Kim [this message]
2016-06-16 15:12 ` Johannes Weiner
2016-06-17 7:49 ` Minchan Kim
2016-06-17 17:01 ` Johannes Weiner
2016-06-20 7:42 ` Minchan Kim
2016-06-22 21:56 ` Johannes Weiner
2016-06-24 6:22 ` Minchan Kim
2016-06-07 9:51 ` [PATCH 00/10] " Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615022341.GF17127@bbox \
--to=minchan@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).