From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id 434026B0005 for ; Mon, 20 Jun 2016 15:27:11 -0400 (EDT) Received: by mail-qk0-f200.google.com with SMTP id 134so317160631qkd.1 for ; Mon, 20 Jun 2016 12:27:11 -0700 (PDT) Received: from mail-yw0-x244.google.com (mail-yw0-x244.google.com. [2607:f8b0:4002:c05::244]) by mx.google.com with ESMTPS id l125si3885702ywe.414.2016.06.20.12.27.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 12:27:10 -0700 (PDT) Received: by mail-yw0-x244.google.com with SMTP id v77so4215195ywg.2 for ; Mon, 20 Jun 2016 12:27:10 -0700 (PDT) Date: Mon, 20 Jun 2016 15:27:08 -0400 From: Tejun Heo Subject: Re: [PATCH v9 02/12] kthread: Kthread worker API cleanup Message-ID: <20160620192708.GT3262@mtj.duckdns.org> References: <1466075851-24013-1-git-send-email-pmladek@suse.com> <1466075851-24013-3-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466075851-24013-3-git-send-email-pmladek@suse.com> Sender: owner-linux-mm@kvack.org List-ID: To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Ingo Molnar , Peter Zijlstra , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Hello, On Thu, Jun 16, 2016 at 01:17:21PM +0200, Petr Mladek wrote: > __init_kthread_worker() -> __kthread_init_worker() > init_kthread_worker() -> kthread_init_worker() > init_kthread_work() -> kthread_init_work() > insert_kthread_work() -> kthread_insert_work() > queue_kthread_work() -> kthread_queue_work() > flush_kthread_work() -> kthread_flush_work() > flush_kthread_worker() -> kthread_flush_worker() I wonder whether the subsystem name here is more the whole kthread_worker rather than just kthread but I can't think of a good single syllable abbrev for it. It's a bikeshedding anyway. > Note that the names of DEFINE_KTHREAD_WORK*() macros stay > as they are. It is common that the "DEFINE_" prefix has > precedence over the subsystem names. > > INIT_() macros are similar to DEFINE_. Therefore this patch > renames: > > KTHREAD_WORKER_INIT() -> INIT_KTHREAD_WORKER() > KTHREAD_WORK_INIT() -> INIT_KTHREAD_WORK() So, they're different. In the above cases, INIT doesn't stand for the verb INITIALIZE but its noun form INITIALIZER. These aren't operations and thus different from DEFINE_XXX(). kthread_init_worker = kthread: initialize worker KTHREAD_WORKER_INIT = kthread: worker initializer I think it makes a lot more sense to keep _INIT at the end for these. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org