From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
kbuild test robot <fengguang.wu@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [PATCH] mm, vmstat: add infrastructure for per-node vmstats -fix
Date: Thu, 23 Jun 2016 10:03:48 +0100 [thread overview]
Message-ID: <20160623090348.GB1800@suse.de> (raw)
In-Reply-To: <201606230905.nsZvjT96%fengguang.wu@intel.com>
The kbuild test robot reported the following
All warnings (new ones prefixed by >>):
drivers/base/node.c: In function 'node_read_meminfo':
>> drivers/base/node.c:126:31: warning: passing argument 1 of 'node_page_state' makes pointer from integer without a cast [-Wint-conversion]
nid, node_page_state(nid, NR_KERNEL_STACK) *
^~~
In file included from include/linux/mm.h:991:0,
from drivers/base/node.c:7:
include/linux/vmstat.h:184:22: note: expected 'struct pglist_data *' but argument is of type 'int'
extern unsigned long node_page_state(struct pglist_data *pgdat,
This may be a problem due to a merge conflict. This is a fix for the mmotm
patch mm-vmstat-add-infrastructure-for-per-node-vmstats.patch
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
drivers/base/node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c
index a3ae3ae34593..0a1b6433a76c 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -123,7 +123,7 @@ static ssize_t node_read_meminfo(struct device *dev,
nid, K(sum_zone_node_page_state(nid, NR_FILE_MAPPED)),
nid, K(sum_zone_node_page_state(nid, NR_ANON_PAGES)),
nid, K(i.sharedram),
- nid, node_page_state(nid, NR_KERNEL_STACK) *
+ nid, sum_zone_node_page_state(nid, NR_KERNEL_STACK) *
THREAD_SIZE / 1024,
nid, K(sum_zone_node_page_state(nid, NR_PAGETABLE)),
nid, K(sum_zone_node_page_state(nid, NR_UNSTABLE_NFS)),
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-06-23 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 1:59 [mmotm:master 182/309] drivers/base/node.c:126:31: warning: passing argument 1 of 'node_page_state' makes pointer from integer without a cast kbuild test robot
2016-06-23 9:03 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623090348.GB1800@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).