From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: 'Johannes Weiner' <hannes@cmpxchg.org>,
'Vlastimil Babka' <vbabka@suse.cz>,
'linux-kernel' <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm, vmscan: Make kswapd reclaim no more than needed
Date: Fri, 24 Jun 2016 10:32:26 +0100 [thread overview]
Message-ID: <20160624093226.GE1868@techsingularity.net> (raw)
In-Reply-To: <082f01d1cdf6$c789a2b0$569ce810$@alibaba-inc.com>
On Fri, Jun 24, 2016 at 04:59:55PM +0800, Hillf Danton wrote:
> We stop reclaiming pages if any eligible zone is balanced.
>
> Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
wakeup_kswapd avoids waking kswapd in the first place if there are balanced
zones. The current code will do at least one reclaim pass if the situation
changes between the wakeup request and kswapd actually waking so some
progress will be made. The risk for strict enforcement is that small low
zones like DMA will be quickly generally balanced but only for very short
periods of time and kswapd will fall behind. It *shouldn't* matter as
the pages allocated from DMA will remain resident until the full node
LRU cycles through but it's a possibility.
I'll test the patch and make sure kswapd still reclaims at the correct
rate. Did you this test yourself with any reclaim intensive workload to
see if kswapd fell behind forcing more stalls in direct reclaim?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-06-24 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 8:59 [PATCH] mm, vmscan: Make kswapd reclaim no more than needed Hillf Danton
2016-06-24 9:32 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624093226.GE1868@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).