From: Minchan Kim <minchan@kernel.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
mingo@redhat.com
Subject: Re: [PATCH 7/8] mm/zsmalloc: add __init,__exit attribute
Date: Mon, 4 Jul 2016 09:09:24 +0900 [thread overview]
Message-ID: <20160704000924.GF19044@bbox> (raw)
In-Reply-To: <1467355266-9735-7-git-send-email-opensource.ganesh@gmail.com>
On Fri, Jul 01, 2016 at 02:41:05PM +0800, Ganesh Mahendran wrote:
> Add __init,__exit attribute for function that is only called in
> module init/exit
to save memory.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
> mm/zsmalloc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 6fc631a..1c7460b 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1349,7 +1349,7 @@ static void zs_unregister_cpu_notifier(void)
> cpu_notifier_register_done();
> }
>
> -static void init_zs_size_classes(void)
> +static void __init init_zs_size_classes(void)
> {
> int nr;
>
> @@ -1896,7 +1896,7 @@ static struct file_system_type zsmalloc_fs = {
> .kill_sb = kill_anon_super,
> };
>
> -static int zsmalloc_mount(void)
> +static int __init zsmalloc_mount(void)
> {
> int ret = 0;
>
> @@ -1907,7 +1907,7 @@ static int zsmalloc_mount(void)
> return ret;
> }
>
> -static void zsmalloc_unmount(void)
> +static void __exit zsmalloc_unmount(void)
> {
> kern_unmount(zsmalloc_mnt);
> }
Couldn't we do it for zs_[un]register_cpu_notifier?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-04 0:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 6:40 [PATCH 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 2/8] mm/zsmalloc: add per class compact trace event Ganesh Mahendran
2016-07-03 23:49 ` Minchan Kim
2016-07-04 3:12 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Ganesh Mahendran
2016-07-03 23:57 ` Minchan Kim
2016-07-04 3:23 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-03 23:58 ` Minchan Kim
2016-07-01 6:41 ` [PATCH 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-04 0:03 ` Minchan Kim
2016-07-04 3:26 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-04 0:05 ` Minchan Kim
2016-07-04 3:32 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-04 0:09 ` Minchan Kim [this message]
2016-07-01 6:41 ` [PATCH 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-04 0:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704000924.GF19044@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).