From: Oleg Nesterov <oleg@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
rientjes@google.com, vdavydov@parallels.com, mst@redhat.com,
mhocko@suse.com, mhocko@kernel.org
Subject: Re: [PATCH 3/8] mm,oom: Use list of mm_struct used by OOM victims.
Date: Mon, 4 Jul 2016 12:39:32 +0200 [thread overview]
Message-ID: <20160704103931.GA3882@redhat.com> (raw)
In-Reply-To: <201607031138.AHB35971.FLVQOtJFOMFHSO@I-love.SAKURA.ne.jp>
Tetsuo,
I'll try to actually read this series later, although I will leave the
actual review to maintainers anyway...
Just a couple of questions for now,
On 07/03, Tetsuo Handa wrote:
>
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -722,6 +722,7 @@ static inline void __mmput(struct mm_struct *mm)
> }
> if (mm->binfmt)
> module_put(mm->binfmt->module);
> + exit_oom_mm(mm);
Is it strictly necessary? At first glance not. Sooner or later oom_reaper() should
find this mm_struct and do exit_oom_mm(). And given that mm->mm_users is already 0
the "extra" __oom_reap_vmas() doesn't really hurt.
It would be nice to remove exit_oom_mm() from __mmput(); it takes the global spinlock
for the very unlikely case, and if we can avoid it here then perhaps we can remove
->oom_mm from mm_struct.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-04 10:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 2:35 [PATCH 0/8] Change OOM killer to use list of mm_struct Tetsuo Handa
2016-07-03 2:36 ` [PATCH 1/8] mm,oom_reaper: Remove pointless kthread_run() failure check Tetsuo Handa
2016-07-03 12:42 ` Oleg Nesterov
2016-07-03 16:03 ` Tetsuo Handa
2016-07-03 17:10 ` Oleg Nesterov
2016-07-03 21:53 ` Tetsuo Handa
2016-07-04 11:13 ` Oleg Nesterov
2016-07-07 11:14 ` Michal Hocko
2016-07-03 2:37 ` [PATCH 2/8] mm,oom_reaper: Reduce find_lock_task_mm() usage Tetsuo Handa
2016-07-07 11:19 ` Michal Hocko
2016-07-03 2:38 ` [PATCH 3/8] mm,oom: Use list of mm_struct used by OOM victims Tetsuo Handa
2016-07-04 10:39 ` Oleg Nesterov [this message]
2016-07-04 12:50 ` Tetsuo Handa
2016-07-04 18:25 ` Oleg Nesterov
2016-07-05 10:43 ` Tetsuo Handa
2016-07-05 20:52 ` Oleg Nesterov
2016-07-06 8:53 ` Oleg Nesterov
2016-07-06 11:43 ` Tetsuo Handa
2016-07-07 11:31 ` Michal Hocko
2016-07-03 2:39 ` [PATCH 4/8] mm,oom: Remove OOM_SCAN_ABORT case Tetsuo Handa
2016-07-03 2:40 ` [PATCH 5/8] mm,oom: Remove unused signal_struct->oom_victims Tetsuo Handa
2016-07-07 14:03 ` Michal Hocko
2016-07-03 2:40 ` [PATCH 6/8] mm,oom_reaper: Stop clearing TIF_MEMDIE on remote thread Tetsuo Handa
2016-07-07 14:06 ` Michal Hocko
2016-07-07 16:10 ` Tetsuo Handa
2016-07-07 16:54 ` Michal Hocko
2016-07-03 2:41 ` [PATCH 7/8] mm,oom_reaper: Pass OOM victim's comm and pid values via mm_struct Tetsuo Handa
2016-07-03 2:41 ` [PATCH 8/8] mm,oom_reaper: Make OOM reaper use list of mm_struct Tetsuo Handa
2016-07-04 10:40 ` Oleg Nesterov
2016-07-07 14:15 ` Michal Hocko
2016-07-07 11:04 ` [PATCH 0/8] Change OOM killer to " Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2016-07-12 13:29 [PATCH v3 " Tetsuo Handa
2016-07-12 13:29 ` [PATCH 3/8] mm,oom: Use list of mm_struct used by OOM victims Tetsuo Handa
2016-07-12 14:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704103931.GA3882@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).