From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f70.google.com (mail-pa0-f70.google.com [209.85.220.70]) by kanga.kvack.org (Postfix) with ESMTP id 2E5206B0005 for ; Mon, 25 Jul 2016 05:07:46 -0400 (EDT) Received: by mail-pa0-f70.google.com with SMTP id q2so321451179pap.1 for ; Mon, 25 Jul 2016 02:07:46 -0700 (PDT) Received: from lgeamrelo13.lge.com (LGEAMRELO13.lge.com. [156.147.23.53]) by mx.google.com with ESMTP id dz8si19801617pab.269.2016.07.25.02.07.44 for ; Mon, 25 Jul 2016 02:07:45 -0700 (PDT) Date: Mon, 25 Jul 2016 18:08:14 +0900 From: Minchan Kim Subject: Re: [PATCH] zsmalloc: Delete an unnecessary check before the function call "iput" Message-ID: <20160725090814.GF1660@bbox> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <559cf499-4a01-25f9-c87f-24d906626a57@users.sourceforge.net> MIME-Version: 1.0 In-Reply-To: <559cf499-4a01-25f9-c87f-24d906626a57@users.sourceforge.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: SF Markus Elfring Cc: linux-mm@kvack.org, Nitin Gupta , Sergey Senozhatsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Fri, Jul 22, 2016 at 08:02:08PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 22 Jul 2016 19:54:20 +0200 > > The iput() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Minchan Kim Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org