From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] shmem: Fix link error if huge pages support is disabled
Date: Wed, 3 Aug 2016 22:04:51 +0300 [thread overview]
Message-ID: <20160803190451.GA9830@node.shutemov.name> (raw)
In-Reply-To: <1470247099-14217-1-git-send-email-geert@linux-m68k.org>
On Wed, Aug 03, 2016 at 07:58:19PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_TRANSPARENT_HUGE_PAGECACHE=n, HPAGE_PMD_NR evaluates to
> BUILD_BUG_ON(), and may cause (e.g. with gcc 4.12):
>
> mm/built-in.o: In function `shmem_alloc_hugepage':
> shmem.c:(.text+0x17570): undefined reference to `__compiletime_assert_1365'
>
> To fix this, move the assignment to hindex after the check for huge
> pages support.
>
> Fixes: 800d8c63b2e989c2 ("shmem: add huge pages support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-08-03 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 17:58 [PATCH] shmem: Fix link error if huge pages support is disabled Geert Uytterhoeven
2016-08-03 19:04 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803190451.GA9830@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).