From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id E7AA36B0069 for ; Fri, 9 Sep 2016 08:36:14 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id v67so182389144pfv.1 for ; Fri, 09 Sep 2016 05:36:14 -0700 (PDT) Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTPS id l6si3747866pav.281.2016.09.09.05.36.13 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 09 Sep 2016 05:36:14 -0700 (PDT) Date: Fri, 9 Sep 2016 15:36:08 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH v4 RESEND 0/2] Align mmap address for DAX pmd mappings Message-ID: <20160909123608.GA75965@black.fi.intel.com> References: <1472497881-9323-1-git-send-email-toshi.kani@hpe.com> <20160829204842.GA27286@node.shutemov.name> <1472506310.1532.47.camel@hpe.com> <1472508000.1532.59.camel@hpe.com> <20160908105707.GA17331@node> <1473342519.2092.42.camel@hpe.com> <1473376846.2092.69.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473376846.2092.69.camel@hpe.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Kani, Toshimitsu" Cc: "kirill@shutemov.name" , "hughd@google.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "adilger.kernel@dilger.ca" , "mike.kravetz@oracle.com" , "dan.j.williams@intel.com" , "mawilcox@microsoft.com" , "akpm@linux-foundation.org" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "tytso@mit.edu" , "david@fromorbit.com" , "jack@suse.cz" On Thu, Sep 08, 2016 at 11:21:46PM +0000, Kani, Toshimitsu wrote: > On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote: > > On Thu, 2016-09-08 at 13:57 +0300, Kirill A. Shutemov wrote: > > > > > > On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote: > : > > > > > > > > Looking further, these shmem_huge handlings only check pre- > > > > conditions. So, we should be able to make shmem_get_unmapped_are > > > > a() as a wrapper, which checks such shmem-specific conitions, and > > > > then call __thp_get_unmapped_area() for the actual work. All > > > > DAX-specific checks are performed in thp_get_unmapped_area() as > > > > well. We can make __thp_get_unmapped_area() as a common > > > > function. > > > > > > > > I'd prefer to make such change as a separate item, > > > > > > Do you have plan to submit such change? > > > > Yes, I will submit the change once I finish testing. > > I found a bug in the current code, and need some clarification. The > if-statement below is reverted. Yeah. It was repored by Hillf[1]. The fixup got lost. :( Could you post a proper patch with the fix? I would be nice to credit Hillf there too. [1] http://lkml.kernel.org/r/054f01d1c86f$2994d5c0$7cbe8140$@alibaba-inc.com -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org