From: Tejun Heo <tj@kernel.org>
To: zijun_hu <zijun_hu@zoho.com>
Cc: zijun_hu@htc.com, Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, cl@linux.com
Subject: Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk()
Date: Fri, 23 Sep 2016 17:30:30 -0400 [thread overview]
Message-ID: <20160923213030.GG31387@htj.duckdns.org> (raw)
In-Reply-To: <39277252-5bf4-b355-c076-8059e693f4aa@zoho.com>
Hello,
On Sat, Sep 24, 2016 at 05:16:56AM +0800, zijun_hu wrote:
> On 2016/9/24 3:23, Tejun Heo wrote:
> > On Sat, Sep 24, 2016 at 02:20:24AM +0800, zijun_hu wrote:
> >> From: zijun_hu <zijun_hu@htc.com>
> >>
> >> correct max_distance from (base of the highest group + ai->unit_size)
> >> to (base of the highest group + the group size)
> >>
> >> Signed-off-by: zijun_hu <zijun_hu@htc.com>
> >
> > Nacked-by: Tejun Heo <tj@kernel.org>
> >
> > Thanks.
> >
> frankly, the current max_distance is error, doesn't represents the ranges spanned by
> areas owned by the groups
I think you're right but can you please update the patch description
so that it explains what the bug and the implications are and how the
patch fixes the bug. Also, please make sure that all changes made by
the patch are explained in the description - e.g. why the type of
@max_distance is changed from size_t to ulong.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-23 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 18:20 [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk() zijun_hu
2016-09-23 19:23 ` Tejun Heo
2016-09-23 21:16 ` zijun_hu
2016-09-23 21:30 ` Tejun Heo [this message]
2016-09-23 23:20 ` [RESEND PATCH " zijun_hu
2016-09-29 10:35 ` Tejun Heo
2016-09-29 11:29 ` zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923213030.GG31387@htj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).