From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Doug Smythies <dsmythies@telus.net>
Cc: 'Johannes Weiner' <hannes@cmpxchg.org>,
'Andrew Morton' <akpm@linux-foundation.org>,
'Vladimir Davydov' <vdavydov.dev@gmail.com>,
bugzilla-daemon@bugzilla.kernel.org, linux-mm@kvack.org
Subject: Re: [Bug 172981] New: [bisected] SLAB: extreme load averages and over 2000 kworker threads
Date: Wed, 28 Sep 2016 15:20:25 +0900 [thread overview]
Message-ID: <20160928062024.GF22706@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <20160928051841.GB22706@js1304-P5Q-DELUXE>
On Wed, Sep 28, 2016 at 02:18:42PM +0900, Joonsoo Kim wrote:
> On Tue, Sep 27, 2016 at 08:13:58PM -0700, Doug Smythies wrote:
> > By the way, I can eliminate the problem by doing this:
> > (see also: https://bugzilla.kernel.org/show_bug.cgi?id=172991)
>
> I think that Johannes found the root cause of the problem and they
> (Johannes and Vladimir) will solve the root cause.
>
> However, there is something useful to do in SLAB side.
> Could you test following patch, please?
>
> Thanks.
>
> ---------->8--------------
> diff --git a/mm/slab.c b/mm/slab.c
> index 0eb6691..39e3bf2 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -965,7 +965,7 @@ static int setup_kmem_cache_node(struct kmem_cache *cachep,
> * guaranteed to be valid until irq is re-enabled, because it will be
> * freed after synchronize_sched().
> */
> - if (force_change)
> + if (n->shared && force_change)
> synchronize_sched();
Oops...
s/n->shared/old_shared/
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-28 6:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-172981-27@https.bugzilla.kernel.org/>
2016-09-27 18:10 ` [Bug 172981] New: [bisected] SLAB: extreme load averages and over 2000 kworker threads Andrew Morton
2016-09-28 2:03 ` Johannes Weiner
2016-09-28 8:09 ` Vladimir Davydov
2016-09-29 2:00 ` Joonsoo Kim
2016-09-29 13:45 ` Vladimir Davydov
2016-09-30 8:19 ` Joonsoo Kim
2016-09-30 19:58 ` Vladimir Davydov
2016-10-06 5:04 ` Doug Smythies
2016-10-06 6:35 ` Joonsoo Kim
2016-10-06 16:02 ` Doug Smythies
2016-10-07 15:55 ` Doug Smythies
2016-09-28 3:13 ` Doug Smythies
2016-09-28 5:18 ` Joonsoo Kim
2016-09-28 6:20 ` Joonsoo Kim [this message]
2016-09-28 15:22 ` Doug Smythies
2016-09-29 1:50 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928062024.GF22706@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=dsmythies@telus.net \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).