From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mgorman@suse.de,
dave.hansen@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: warn about allocations which stall for too long
Date: Thu, 29 Sep 2016 11:10:40 +0200 [thread overview]
Message-ID: <20160929091040.GE408@dhcp22.suse.cz> (raw)
In-Reply-To: <201609291802.GFG81203.FLHtOMSJOVFFQO@I-love.SAKURA.ne.jp>
On Thu 29-09-16 18:02:44, Tetsuo Handa wrote:
[...]
> > @@ -3650,6 +3652,14 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
> > if (order > PAGE_ALLOC_COSTLY_ORDER && !(gfp_mask & __GFP_REPEAT))
> > goto nopage;
> >
> > + /* Make sure we know about allocations which stall for too long */
> > + if (time_after(jiffies, alloc_start + stall_timeout)) {
> > + warn_alloc(gfp_mask,
>
> I expect "gfp_mask & ~__GFP_NOWARN" rather than "gfp_mask" here.
> Otherwise, we can't get a clue for __GFP_NOWARN allocations.
If there is an explicit __GFP_NOWARN then I believe we should obey it
same way we do for the allocation failure. If you believe this is not
the best way then feel free to send a patch with an example where a
__GFP_NOWARN user would really like to see about the stall.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-09-29 9:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 8:15 [PATCH] mm: warn about allocations which stall for too long Michal Hocko
2016-09-23 8:29 ` Hillf Danton
2016-09-23 8:32 ` Michal Hocko
2016-09-23 8:44 ` Hillf Danton
2016-09-23 9:15 ` Michal Hocko
2016-09-23 14:36 ` Tetsuo Handa
2016-09-23 15:02 ` Michal Hocko
2016-09-24 3:00 ` Tetsuo Handa
2016-09-26 8:17 ` Michal Hocko
2016-09-27 12:57 ` Tetsuo Handa
2016-09-29 8:48 ` Michal Hocko
2016-09-23 17:34 ` Dave Hansen
2016-09-24 13:19 ` Balbir Singh
2016-09-26 8:13 ` Michal Hocko
2016-09-26 8:12 ` Michal Hocko
2016-09-29 8:44 ` [PATCH 0/2] " Michal Hocko
2016-09-29 8:44 ` [PATCH 1/2] mm: consolidate warn_alloc_failed users Michal Hocko
2016-09-29 9:23 ` Vlastimil Babka
2016-09-29 8:44 ` [PATCH 2/2] mm: warn about allocations which stall for too long Michal Hocko
2016-09-29 9:02 ` Tetsuo Handa
2016-09-29 9:10 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929091040.GE408@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).