From: Tejun Heo <tj@kernel.org>
To: zijun_hu <zijun_hu@zoho.com>
Cc: akpm@linux-foundation.org, zijun_hu@htc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cl@linux.com
Subject: Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm
Date: Thu, 13 Oct 2016 19:37:22 -0400 [thread overview]
Message-ID: <20161013233722.GF32534@mtj.duckdns.org> (raw)
In-Reply-To: <701fa92a-026b-f30b-833c-a5e61eab6549@zoho.com>
Hello, Zijun.
On Tue, Oct 11, 2016 at 08:48:45PM +0800, zijun_hu wrote:
> compared with the original algorithm theoretically and practically, the
> new one educes the same grouping results, besides, it is more effective,
> simpler and easier to understand.
If the original code wasn't broken and the new code produces the same
output, I'd really not mess with this code. There simply is no upside
to messing with this code. It's run once during boot and never a
noticeable contributor of boot overhead. Maybe the new code is a bit
simpler and more efficient but the actual benefit is so small that any
risk would outweigh it.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-13 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 12:48 [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm zijun_hu
2016-10-11 12:53 ` zijun_hu
2016-10-13 23:37 ` Tejun Heo [this message]
2016-10-13 23:49 ` zijun_hu
2016-10-14 0:33 ` Tejun Heo
2016-10-14 1:17 ` zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013233722.GF32534@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).