From: Mark Rutland <mark.rutland@arm.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, Joe Perches <joe@perches.com>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH] mm: pagealloc: fix continued prints in show_free_areas
Date: Tue, 18 Oct 2016 14:04:35 +0100 [thread overview]
Message-ID: <20161018130435.GD15639@leverpostej> (raw)
In-Reply-To: <d92624ee-76f2-5e42-8318-94ddf0f22bbf@suse.cz>
On Tue, Oct 18, 2016 at 03:00:40PM +0200, Vlastimil Babka wrote:
> On 10/18/2016 01:34 PM, Mark Rutland wrote:
> >In show_free_areas, we miss KERN_CONT in a few cases, and as a result
> >prints are unexpectedly split over a number of lines, making them
> >difficult to read (in v4.9-rc1).
> >
> >This patch uses pr_cont (with uits implicit KERN_CONT) to mark all
> >continued prints that occur withing a show_free_areas() call. Note that
> >show_migration_types() is only called by show_free_areas().
> >Depending on CONFIG_NUMA a printk after show_node() may or may not be a
> >continuation, but follows an explicit newline if not (and thus marking
> >it as a continuation should not be harmful).
>
> I think this was already fixed:
>
> http://marc.info/?l=linux-mm&m=147623910031630&w=2
So it was; thanks for the pointer!
Thanks,
Mark.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-18 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 11:34 [PATCH] mm: pagealloc: fix continued prints in show_free_areas Mark Rutland
2016-10-18 13:00 ` Vlastimil Babka
2016-10-18 13:04 ` Mark Rutland [this message]
2016-10-18 13:44 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018130435.GD15639@leverpostej \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).