From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 39F15280256 for ; Thu, 3 Nov 2016 18:17:03 -0400 (EDT) Received: by mail-pf0-f198.google.com with SMTP id 83so15466569pfx.1 for ; Thu, 03 Nov 2016 15:17:03 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id 18si11896857pfh.177.2016.11.03.15.17.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Nov 2016 15:17:02 -0700 (PDT) Date: Thu, 3 Nov 2016 15:17:00 -0700 From: Andrew Morton Subject: Re: [PATCH] z3fold: make pages_nr atomic Message-Id: <20161103151700.73a98155238acff3f3f98e8b@linux-foundation.org> In-Reply-To: References: <20161103220058.3017148c790b352c0ec521d4@gmail.com> <20161103141404.2bb6b59435e560f0b82c0a18@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vitaly Wool Cc: Linux-MM , LKML , Dan Streetman On Thu, 3 Nov 2016 22:24:07 +0100 Vitaly Wool wrote: > On Thu, Nov 3, 2016 at 10:14 PM, Andrew Morton > wrote: > > On Thu, 3 Nov 2016 22:00:58 +0100 Vitaly Wool wrote: > > > >> This patch converts pages_nr per-pool counter to atomic64_t. > > > > Which is slower. > > > > Presumably there is a reason for making this change. This reason > > should be described in the changelog. > > The reason [which I thought was somewhat obvious :) ] is that there > won't be a need to take a per-pool lock to read or modify that > counter. But the patch didn't change the locking. And as far as I can tell, neither does "z3fold: extend compaction function". -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org