From: "tj@kernel.org" <tj@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: Wei Chen <Wei.Chen@arm.com>,
"zijun_hu@htc.com" <zijun_hu@htc.com>,
"cl@linux.com" <cl@linux.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Kaly Xin <Kaly.Xin@arm.com>, Steve Capper <Steve.Capper@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: Kernel Panics on Xen ARM64 for Domain0 and Guest
Date: Mon, 28 Nov 2016 10:29:15 -0500 [thread overview]
Message-ID: <20161128152915.GA7806@htj.duckdns.org> (raw)
In-Reply-To: <420a44c0-f86f-e6ab-44af-93ada7e01b58@arm.com>
Hello,
On Mon, Nov 28, 2016 at 11:59:15AM +0000, Julien Grall wrote:
> > commit 3ca45a46f8af8c4a92dd8a08eac57787242d5021
> > percpu: ensure the requested alignment is power of two
>
> It would have been useful to specify the tree used. In this case,
> this commit comes from linux-next.
I'm surprised this actually triggered.
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index f193414..4986dc0 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -372,8 +372,7 @@ static int __init xen_guest_init(void)
> * for secondary CPUs as they are brought up.
> * For uniformity we use VCPUOP_register_vcpu_info even on cpu0.
> */
> - xen_vcpu_info = __alloc_percpu(sizeof(struct vcpu_info),
> - sizeof(struct vcpu_info));
> + xen_vcpu_info = alloc_percpu(struct vcpu_info);
> if (xen_vcpu_info == NULL)
> return -ENOMEM;
Yes, this looks correct. Can you please cc stable too? percpu
allocator never supported alignments which aren't power of two and has
always behaved incorrectly with alignments which aren't power of two.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-28 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 9:38 Kernel Panics on Xen ARM64 for Domain0 and Guest Wei Chen
2016-11-28 11:59 ` Julien Grall
2016-11-28 15:29 ` tj [this message]
2016-12-01 17:31 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128152915.GA7806@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Kaly.Xin@arm.com \
--cc=Steve.Capper@arm.com \
--cc=Wei.Chen@arm.com \
--cc=cl@linux.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zijun_hu@htc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).