From: Eric Biggers <ebiggers3@gmail.com>
To: kernel-hardening@lists.openwall.com
Cc: Andy Lutomirski <luto@amacapital.net>,
linux-crypto@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Lutomirski <luto@kernel.org>,
Stephan Mueller <smueller@chronox.de>
Subject: Re: [kernel-hardening] Re: Remaining crypto API regressions with CONFIG_VMAP_STACK
Date: Fri, 9 Dec 2016 22:03:16 -0800 [thread overview]
Message-ID: <20161210060316.GC6846@zzz> (raw)
In-Reply-To: <20161210053208.GA27951@gondor.apana.org.au>
On Sat, Dec 10, 2016 at 01:32:08PM +0800, Herbert Xu wrote:
> On Fri, Dec 09, 2016 at 09:25:38PM -0800, Andy Lutomirski wrote:
> >
> > > The following crypto drivers initialize a scatterlist to point into an
> > > ablkcipher_request, which may have been allocated on the stack with
> > > SKCIPHER_REQUEST_ON_STACK():
> > >
> > > drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
> > > drivers/crypto/ccp/ccp-crypto-aes.c:94
> >
> > These are real, and I wish I'd known about them sooner.
>
> Are you sure? Any instance of *_ON_STACK must only be used with
> sync algorithms and most drivers under drivers/crypto declare
> themselves as async.
>
Why exactly is that? Obviously, it wouldn't work if you returned from the stack
frame before the request completed, but does anything stop someone from using an
*_ON_STACK() request and then waiting for the request to complete before
returning from the stack frame?
Eric
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-10 6:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 23:08 Remaining crypto API regressions with CONFIG_VMAP_STACK Eric Biggers
2016-12-10 5:25 ` Andy Lutomirski
2016-12-10 5:32 ` Herbert Xu
2016-12-10 6:03 ` Eric Biggers [this message]
2016-12-10 8:16 ` [kernel-hardening] " Herbert Xu
2016-12-10 8:39 ` Eric Biggers
2016-12-10 5:37 ` Herbert Xu
2016-12-10 6:30 ` [kernel-hardening] " Eric Biggers
2016-12-10 14:45 ` Jason A. Donenfeld
2016-12-10 17:48 ` Andy Lutomirski
2016-12-10 5:55 ` Eric Biggers
2016-12-11 19:13 ` Andy Lutomirski
2016-12-11 23:31 ` Eric Biggers
2016-12-12 18:34 ` Andy Lutomirski
2016-12-12 18:45 ` Gary R Hook
2016-12-13 3:39 ` Herbert Xu
2016-12-13 3:39 ` Herbert Xu
2016-12-13 17:06 ` Andy Lutomirski
2016-12-14 4:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210060316.GC6846@zzz \
--to=ebiggers3@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).