From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-mm@kvack.org, linux-ext4@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>, Jan Kara <jack@suse.cz>
Subject: [PATCH 1/6] ext2: Return BH_New buffers for zeroed blocks
Date: Mon, 12 Dec 2016 17:47:03 +0100 [thread overview]
Message-ID: <20161212164708.23244-2-jack@suse.cz> (raw)
In-Reply-To: <20161212164708.23244-1-jack@suse.cz>
So far we did not return BH_New buffers from ext2_get_blocks() when we
allocated and zeroed-out a block for DAX inode to avoid racy zeroing in
DAX code. This zeroing is gone these days so we can remove the
workaround.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext2/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 046b642f3585..e626fe892c01 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -754,9 +754,8 @@ static int ext2_get_blocks(struct inode *inode,
mutex_unlock(&ei->truncate_mutex);
goto cleanup;
}
- } else {
- *new = true;
}
+ *new = true;
ext2_splice_branch(inode, iblock, partial, indirect_blks, count);
mutex_unlock(&ei->truncate_mutex);
--
2.10.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-12 16:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:47 [PATCH 0/6 v3] dax: Page invalidation fixes Jan Kara
2016-12-12 16:47 ` Jan Kara [this message]
2016-12-12 16:47 ` [PATCH 2/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-12-12 17:50 ` Johannes Weiner
2016-12-12 16:47 ` [PATCH 3/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-12-12 16:47 ` [PATCH 4/6] dax: Finish fault completely when loading holes Jan Kara
2016-12-12 16:47 ` [PATCH 5/6] dax: Call ->iomap_begin without entry lock during dax fault Jan Kara
2016-12-12 16:47 ` [PATCH 6/6] ext4: Simplify DAX fault path Jan Kara
2016-12-12 17:51 ` [PATCH 0/6 v3] dax: Page invalidation fixes Johannes Weiner
2016-12-13 11:52 ` Jan Kara
2016-12-13 18:57 ` Dan Williams
2016-12-17 1:35 ` Dan Williams
2016-12-17 1:49 ` Dan Williams
2016-12-19 9:56 ` Jan Kara
2016-12-19 21:51 ` Dan Williams
2016-12-20 7:59 ` Jan Kara
2016-12-20 20:09 ` Dan Williams
2016-12-13 20:01 ` Dave Chinner
2016-12-13 20:42 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2016-11-24 9:46 [PATCH 0/6 v2] " Jan Kara
2016-11-24 9:46 ` [PATCH 1/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-11-29 17:48 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212164708.23244-2-jack@suse.cz \
--to=jack@suse.cz \
--cc=hannes@cmpxchg.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).