From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
mpe@ellerman.id.au, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/thp/pagecache/collapse: Free the pte page table on collapse for thp page cache.
Date: Tue, 13 Dec 2016 00:02:09 +0300 [thread overview]
Message-ID: <20161212210209.GC10202@node.shutemov.name> (raw)
In-Reply-To: <20161212163428.6780-2-aneesh.kumar@linux.vnet.ibm.com>
On Mon, Dec 12, 2016 at 10:04:28PM +0530, Aneesh Kumar K.V wrote:
> With THP page cache, when trying to build a huge page from regular pte pages,
> we just clear the pmd entry. We will take another fault and at that point we
> will find the huge page in the radix tree, thereby using the huge page to
> complete the page fault
>
> The second fault path will allocate the needed pgtable_t page for archs like
> ppc64. So no need to deposit the same in collapse path. Depositing them in
> the collapse path resulting in a pgtable_t memory leak also giving errors like
> "[ 2362.021762] BUG: non-zero nr_ptes on freeing mm: 3"
>
> Fixes:"mm: THP page cache support for ppc64"
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-12 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:34 [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit Aneesh Kumar K.V
2016-12-12 16:34 ` [PATCH 2/2] mm/thp/pagecache/collapse: Free the pte page table on collapse for thp page cache Aneesh Kumar K.V
2016-12-12 21:02 ` Kirill A. Shutemov [this message]
2016-12-12 21:01 ` [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212210209.GC10202@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).