From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
'Vlastimil Babka' <vbabka@suse.cz>,
'Tetsuo Handa' <penguin-kernel@I-love.SAKURA.ne.jp>,
'Johannes Weiner' <hannes@cmpxchg.org>,
'Mel Gorman' <mgorman@suse.de>,
'David Rientjes' <rientjes@google.com>,
linux-mm@kvack.org, 'LKML' <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] mm: consolidate GFP_NOFAIL checks in the allocator slowpath
Date: Thu, 15 Dec 2016 11:28:38 +0100 [thread overview]
Message-ID: <20161215102838.GA8602@dhcp22.suse.cz> (raw)
In-Reply-To: <04b001d256a8$7bc813d0$73583b70$@alibaba-inc.com>
On Thu 15-12-16 15:54:37, Hillf Danton wrote:
> On Wednesday, December 14, 2016 11:07 PM Michal Hocko wrote:
[...]
> > /* Avoid allocations with no watermarks from looping endlessly */
> > - if (test_thread_flag(TIF_MEMDIE) && !(gfp_mask & __GFP_NOFAIL))
> > + if (test_thread_flag(TIF_MEMDIE))
> > goto nopage;
> >
> Nit: currently we allow TIF_MEMDIE & __GFP_NOFAIL request to
> try direct reclaim. Are you intentionally reclaiming that chance?
That is definitely not a nit! Thanks for catching that. We definitely
shouldn't bypass the direct reclaim because that would mean we rely on
somebody else makes progress for us.
Updated patch below:
---
next prev parent reply other threads:[~2016-12-15 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 15:07 [PATCH] mm: consolidate GFP_NOFAIL checks in the allocator slowpath Michal Hocko
2016-12-14 20:35 ` Johannes Weiner
2016-12-15 7:54 ` Hillf Danton
2016-12-15 10:28 ` Michal Hocko [this message]
2016-12-16 11:39 ` [PATCH v2] " Tetsuo Handa
2016-12-16 11:50 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215102838.GA8602@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).