From: Michal Hocko <mhocko@kernel.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
labbott@redhat.com, m.szyprowski@samsung.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com
Subject: Re: [PATCH] mm: cma: print allocation failure reason and bitmap status
Date: Mon, 2 Jan 2017 09:47:30 +0100 [thread overview]
Message-ID: <20170102084730.GA18048@dhcp22.suse.cz> (raw)
In-Reply-To: <xa1tpok6igqb.fsf@mina86.com>
On Sun 01-01-17 22:59:40, Michal Nazarewicz wrote:
[...]
> Actually, Linux style is more like:
>
> #ifdef CONFIG_CMA_DEBUG
> static void cma_debug_show_areas()
> {
> a?|
> }
> #else
> static inline void cma_debug_show_areas() { }
> #endif
yes, we usually do that when the function is externally visible. Inline
ifdef for static functions saves few lines. Not that it would matter
much though.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-01-02 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161229022722epcas5p4be0e1924f3c8d906cbfb461cab8f0374@epcas5p4.samsung.com>
2016-12-29 2:28 ` [PATCH] mm: cma: print allocation failure reason and bitmap status Jaewon Kim
2016-12-29 9:14 ` Michal Hocko
2016-12-29 9:26 ` Jaewon Kim
2016-12-29 9:43 ` Michal Hocko
2016-12-30 6:27 ` Jaewon Kim
2016-12-29 14:20 ` Michal Nazarewicz
2016-12-30 7:24 ` Jaewon Kim
2016-12-30 9:44 ` Michal Hocko
2017-01-01 21:59 ` Michal Nazarewicz
2017-01-02 5:42 ` Jaewon Kim
2017-01-02 6:46 ` Michal Nazarewicz
2017-01-02 8:06 ` Jaewon Kim
2017-01-02 8:47 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102084730.GA18048@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon31.kim@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).