From: Tejun Heo <tj@kernel.org>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: vdavydov.dev@gmail.com, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org, jsvana@fb.com,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 7/8] slab: remove synchronous synchronize_sched() from memcg cache deactivation path
Date: Tue, 17 Jan 2017 08:42:38 -0800 [thread overview]
Message-ID: <20170117164238.GA28948@mtj.duckdns.org> (raw)
In-Reply-To: <20170117002611.GC25218@js1304-P5Q-DELUXE>
On Tue, Jan 17, 2017 at 09:26:11AM +0900, Joonsoo Kim wrote:
> > + INIT_WORK(&s->memcg_params.deact_work, kmemcg_deactivate_workfn);
> > + schedule_work(&s->memcg_params.deact_work);
> > +}
>
> Isn't it better to submit one work item for each memcg like as
> Vladimir did? Or, could you submit this work to the ordered workqueue?
> I'm not an expert about workqueue like as you, but, I think
> that there is a chance to create a lot of threads if there is
> the slab_mutex lock contention.
Yeah, good point. I'll switch it to its own workqueue w/ concurrency
limited to one.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-17 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 18:48 [PATCHSET v2] slab: make memcg slab destruction scalable Tejun Heo
2017-01-14 18:48 ` [PATCH 1/8] Revert "slub: move synchronize_sched out of slab_mutex on shrink" Tejun Heo
2017-01-14 18:48 ` [PATCH 2/8] slab: remove synchronous rcu_barrier() call in memcg cache release path Tejun Heo
2017-01-14 18:48 ` [PATCH 3/8] slab: reorganize memcg_cache_params Tejun Heo
2017-01-14 18:48 ` [PATCH 4/8] slab: link memcg kmem_caches on their associated memory cgroup Tejun Heo
2017-01-14 18:48 ` [PATCH 5/8] slab: implement slab_root_caches list Tejun Heo
2017-01-14 18:48 ` [PATCH 6/8] slab: introduce __kmemcg_cache_deactivate() Tejun Heo
2017-01-14 18:48 ` [PATCH 7/8] slab: remove synchronous synchronize_sched() from memcg cache deactivation path Tejun Heo
2017-01-17 0:26 ` Joonsoo Kim
2017-01-17 16:42 ` Tejun Heo [this message]
2017-01-14 18:48 ` [PATCH 8/8] slab: remove slub sysfs interface files early for empty memcg caches Tejun Heo
2017-01-17 0:12 ` [PATCHSET v2] slab: make memcg slab destruction scalable Joonsoo Kim
2017-01-17 16:49 ` Tejun Heo
2017-01-18 7:54 ` Joonsoo Kim
2017-01-18 21:01 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117164238.GA28948@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jsvana@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).